Skip to content

refactor: Move Sprocket JS files to Webpack (Part 2) - #3030

Draft
arkirchner wants to merge 5 commits into
mainfrom
ak/move_sprocket_assets_to_webpack_part_2
Draft

refactor: Move Sprocket JS files to Webpack (Part 2)#3030
arkirchner wants to merge 5 commits into
mainfrom
ak/move_sprocket_assets_to_webpack_part_2

Conversation

@arkirchner

@arkirchnerarkirchner commented Jul 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Code editor modules are moved with minimal changes.

The editor is tested in the exercise implimentaion page. Admin exercise page and the RfC page.

Relates to #3021

@arkirchnerarkirchner self-assigned this Jul 22, 2025
@arkirchnerarkirchner added the javascript Pull requests that update Javascript code label Jul 22, 2025
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_2 branch from 077f5f9 to 82a05a6CompareJuly 22, 2025 12:54
arkirchner
arkirchner commented Jul 22, 2025
View reviewed changes
Comment threadapp/javascript/sprocket_asset_import/editor/editor.js Outdated
@codecov

codecovBot commented Jul 22, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (97de3f3) to head (c60094e).
⚠️ Report is 154 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3030 +/- ##
=======================================
Coverage 70.08% 70.08% =======================================
Files 215 215 Lines 6850 6850 =======================================
Hits 4801 4801 Misses 2049 2049

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkirchner
arkirchner marked this pull request as ready for review July 22, 2025 13:16
@arkirchner
arkirchner marked this pull request as draft July 22, 2025 13:33
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_2 branch 2 times, most recently from 8d3ef65 to c4be790CompareJuly 22, 2025 15:00
arkirchner
arkirchner commented Jul 22, 2025
View reviewed changes
Comment threadapp/javascript/sprocket_asset_import/editor/editor.js
var newMode = 'ace/mode/text'

$.ajax(this.fileTypeURL + '/' + fileTypeID, {
$.ajax(this.fileTypeURL() + '/' + fileTypeID, {

@arkirchnerarkirchnerJul 22, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routes.js needs the page to be rendered before execution. Calling this on execution ensures the page is present.

@arkirchner
arkirchner marked this pull request as ready for review July 22, 2025 15:11
ibrahimkonuk
ibrahimkonuk reviewed Jul 22, 2025
View reviewed changes

@ibrahimkonukibrahimkonuk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but haven't tested locally

christophblessing
christophblessing requested changes Jul 23, 2025
View reviewed changes

@christophblessingchristophblessing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the failing specs? Your changes seem not functional.

MrSerth
MrSerth requested changes Jul 23, 2025
View reviewed changes

@MrSerthMrSerth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine, core aspects of the application are broken, such as the navigation. In addition, errors are given on the console, which reminds me of #2953 (review).

Image

@arkirchner
arkirchner marked this pull request as draft July 28, 2025 07:00
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_2 branch from c4be790 to 1062f2dCompareJuly 28, 2025 08:37
arkirchner
arkirchner commented Jul 28, 2025
View reviewed changes
Comment threadapp/javascript/sprocket-asset-import/editor/editor.js
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_2 branch from 1062f2d to 5518e2bCompareJuly 28, 2025 09:23
@MrSerthMrSerth mentioned this pull request Jul 30, 2025
Merged
3 tasks
@arkirchner
refactor: Move Sprocket JS files to Webpack (Part 1)
63093d8
JavaScript for RfCs, Flashes and the color mode can be moved without
modifications.
Relates to #3021
@arkirchner
kebab case
448b6d9
@arkirchner
Move flash messages CSS to app.
721f80e
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_1 branch from ddb6a43 to 721f80eCompareJuly 30, 2025 11:50
@arkirchner
refactor: Move Sprocket JS files to Webpack (Part 2)
85c490b
Code editor modules are moved and modularized for later removal from
global scope.
Relates to #3021
@arkirchner
Import routes directly.
c60094e
@arkirchner
arkirchnerforce-pushed the ak/move_sprocket_assets_to_webpack_part_2 branch from 5518e2b to c60094eCompareJuly 30, 2025 12:30
Base automatically changed from ak/move_sprocket_assets_to_webpack_part_1 to mainAugust 1, 2025 15:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophblessingchristophblessingchristophblessing requested changes
@ibrahimkonukibrahimkonukibrahimkonuk left review comments
@MrSerthMrSerthMrSerth requested changes

Assignees

@arkirchnerarkirchner

Labels

javascriptPull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arkirchner@MrSerth@christophblessing@ibrahimkonuk