Uh oh!
There was an error while loading. Please reload this page.
Python: Fix Shadowing a Variable in Mesh - #582
Merged
Merged
Conversation
Fix a variable shadowing in the Python `Mesh` constructor.
ax3lforce-pushed
the
topic-enableWshadow
branch
from
October 31, 2019 23:14
391f3b2 to
473d6a5CompareTest for `-Wshadow` warnings even when building with pybind11. We introduced a `SYSTEM` option to link pybind11 headers and CPython headers, which we can use in pybind11 2.3.0+ now :)
ax3lforce-pushed
the
topic-enableWshadow
branch
from
October 31, 2019 23:20
473d6a5 to
87d0e5dCompareax3lforce-pushed
the
topic-enableWshadow
branch
3 times, most recently
from
November 2, 2019 23:36
f5e3fc4 to
59591f4Compareax3lforce-pushed
the
topic-enableWshadow
branch
from
November 4, 2019 01:58
59591f4 to
54072dcCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for
-Wshadowwarnings even when building with pybind11. We introduced aSYSTEMoption to link pybind11 headers and CPython headers pybind/pybind11#1416, which we can now use since we depend on pybind11 2.3.0+ (#525) :)