Skip to content

Feat/add missing translations - #1046

Open
jona159 wants to merge 5 commits into
devfrom
feat/add-missing-translations
Open

Feat/add missing translations#1046
jona159 wants to merge 5 commits into
devfrom
feat/add-missing-translations

Conversation

@jona159

Copy link
Copy Markdown
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@jona159jona159 linked an issue Aug 3, 2026 that may be closed by this pull request
3 tasks
@github-actions

github-actionsBot commented Aug 3, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines65.97%2242 / 3398
🔵Statements64.51%2316 / 3590
🔵Functions63.21%433 / 685
🔵Branches50.79%1080 / 2126
File CoverageNo changed files found.
Generated in workflow #2858 for commit d0f33c2 by the Vitest Coverage Report Action

@scheidtdavscheidtdav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Lets just figure out what we do with date-fns :-) I saw that even functions like formatDistanceToNow can be achieved using Intl.RelativeTimeFormat.

Comment on lines +345 to +348
title={t('last_updated')}
text={format(new Date(data.device.updatedAt), 'PPP', {
locale: dateLocale,
})}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to commit on using date-fns?
Intl.DateTimeFormat is well supported and browser-native.
Personally I prefer having that to reduce imports, dependencies and potentially amount of code.
But I am totally willing to be proven differently.

Using Intl.DateTimeFormat this would be (and it passes the i18n.locale directly, which is nice):

new Intl.DateTimeFormat(i18n.language, {
year: 'numeric',
month: 'long',
day: 'numeric',
}).format(new Date(data.device.updatedAt));

Does new Date(data.device.updatedAt).toLocaleString(i18n.language) maybe work too?

@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@jona159, you've reached your PR review limit, so we couldn't start this review.

Next review available in:12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3edf58b3-95da-47f0-a9bd-808bd31f816c

📥 Commits

Reviewing files that changed from the base of the PR and between f8551e9 and d0f33c2.

📒 Files selected for processing (17)
  • app/components/device-detail/device-detail-box.tsx
  • app/components/device-detail/entry-logs.tsx
  • app/components/device-detail/share-link.tsx
  • app/components/mydevices/dt/columns.tsx
  • app/components/rjsf/arrayFieldTemplate.tsx
  • app/routes/device.$deviceId.edit.logs.tsx
  • app/routes/device.$deviceId.edit.tsx
  • public/locales/de/data-table.json
  • public/locales/de/device-detail-box.json
  • public/locales/de/device-overview.json
  • public/locales/de/edit-device-logs.json
  • public/locales/de/ui-components.json
  • public/locales/en/data-table.json
  • public/locales/en/device-detail-box.json
  • public/locales/en/device-overview.json
  • public/locales/en/edit-device-logs.json
  • public/locales/en/ui-components.json

Comment @coderabbitai help to get the list of available commands.

@jona159

Copy link
Copy Markdown
ContributorAuthor

Looking good. Lets just figure out what we do with date-fns :-) I saw that even functions like formatDistanceToNow can be achieved using Intl.RelativeTimeFormat.

Looking good. Lets just figure out what we do with date-fns :-) I saw that even functions like formatDistanceToNow can be achieved using Intl.RelativeTimeFormat.

I am on the same page on the issue of reducing dependencies, i removed the format method from date-fns in the component and replaced it with a formatter using the code you provided above. To get rid of date-fns entirely would probably require more than some simple replacements though as we use the library in some ui components where some of its methods come in very handy i think. Should we make this a seperate issue?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add missing German translations

2 participants

@jona159@scheidtdav