Uh oh!
There was an error while loading. Please reload this page.
chore: Specify C# version - #240
Draft
Reikyo wants to merge 34 commits into
Draft
Annotations
10 warnings
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L373
Consider calling ConfigureAwait on the awaited task |
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L365
Consider calling ConfigureAwait on the awaited task |
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L22
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) |
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L23
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. |
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). |
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). |
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Exceptions should be public |
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L38
Avoid empty interfaces |
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L153
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. |
The logs for this run have expired and are no longer available.
Loading