Skip to content

Update data models - #111

Open
openactive-bot wants to merge 1 commit into
masterfrom
ci/update-data-models
Open

Update data models#111
openactive-bot wants to merge 1 commit into
masterfrom
ci/update-data-models

Conversation

@openactive-bot

Copy link
Copy Markdown
Contributor

Update PHP data models to the latest version based on the OpenActive Vocabulary (codified by the Data Models), Test Interface and Beta Namespace.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't have a class called Class in PHP

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

DateTime::toISO8601() is also not a method, its just DateTime::ISO8601();

Erroneous line:

$sessionSeries->getStartDate()->toISO8601()

Docs ref: https://www.php.net/manual/en/class.datetimeinterface.php#datetimeinterface.constants.iso8601

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the autoloader never loaded it because it was never used before?

<?php// Try to make a class called Classclass Class {
publicfunction__construct()
{
echo'hi';
}
}
$myClass = newClass();

running this script gives: Parse error: syntax error, unexpected token "class", expecting identifier in class-test.php on line 4 expected output is hi.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense! Given the error was already here I wonder if we merge this PR and then solve this issue separately?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 5.6 test is failing for a different reason (this one: #111 (comment)) to the 7.4 test.

But it seams reasonable to move the class thing to a new issue

@nickevansuk

Copy link
Copy Markdown
Contributor

I've created #112 which should allow this to pass?

@openactive-bot
openactive-botforce-pushed the ci/update-data-models branch 2 times, most recently from 6b27a78 to 9c17707CompareJanuary 30, 2025 03:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@openactive-bot@nickevansuk@nathansalter@drinkynet