Uh oh!
There was an error while loading. Please reload this page.
Update data models - #111
Conversation
3e6dd3e to
1efb644CompareThere was a problem hiding this comment.
You can't have a class called Class in PHP
There was a problem hiding this comment.
:)
DateTime::toISO8601() is also not a method, its just DateTime::ISO8601();
Erroneous line:
Docs ref: https://www.php.net/manual/en/class.datetimeinterface.php#datetimeinterface.constants.iso8601
There was a problem hiding this comment.
Strange as the class called Class existed previously: https://github.com/openactive/models-php/blob/f78e51db0d329636a504ecc13409d8af7aab4713/src/Models/SchemaOrg/Class.php
There was a problem hiding this comment.
Maybe the autoloader never loaded it because it was never used before?
<?php// Try to make a class called Classclass Class {
publicfunction__construct()
{
echo'hi';
}
}
$myClass = newClass();running this script gives: Parse error: syntax error, unexpected token "class", expecting identifier in class-test.php on line 4 expected output is hi.
There was a problem hiding this comment.
Make sense! Given the error was already here I wonder if we merge this PR and then solve this issue separately?
There was a problem hiding this comment.
The 5.6 test is failing for a different reason (this one: #111 (comment)) to the 7.4 test.
But it seams reasonable to move the class thing to a new issue
nickevansuk
commented
May 23, 2024
I've created #112 which should allow this to pass? |
dcde052 to
04a8a7bCompare6b27a78 to
9c17707Compare9c17707 to
6bbc642Compare
Update PHP data models to the latest version based on the OpenActive Vocabulary (codified by the Data Models), Test Interface and Beta Namespace.