Skip to content

(cleanup) add link to https://cookbook.openai.com for apply_patch and minor tidy up - #2

Merged
ibigio merged 1 commit into
mainfrom
tibo/codex/1
Apr 16, 2025
Merged

(cleanup) add link to https://cookbook.openai.com for apply_patch and minor tidy up#2
ibigio merged 1 commit into
mainfrom
tibo/codex/1

Conversation

@tibo-openai

Copy link
Copy Markdown
Collaborator

No description provided.

@tibo-openaitibo-openai changed the title (cleanup) add link to https://cookbook.openai.com and minor tidy up(cleanup) add link to https://cookbook.openai.com for apply_patch and minor tidy upApr 16, 2025
@ibigio
ibigio merged commit 1c26c27 into mainApr 16, 2025
@ibigio
ibigio deleted the tibo/codex/1 branch April 16, 2025 17:15
rumple pushed a commit to rumple/codex that referenced this pull request Apr 24, 2025
avalanchexia pushed a commit to avalanchexia/codex that referenced this pull request Jun 7, 2025
mazdak pushed a commit to mazdak/codex that referenced this pull request Sep 3, 2025
shepting pushed a commit to shepting/codex that referenced this pull request Sep 16, 2025
@techjoectechjoec mentioned this pull request Nov 2, 2025
DioNanos referenced this pull request in DioNanos/codex-termux Nov 15, 2025
Critical bugfix - auto-update detection now working
Fixes:
- Version parser now handles -termux suffix correctly
- Tag parser accepts both rust-v* and v*-termux formats
- Added test coverage for Termux tag validation
Technical details:
- v0.58.0 upstream merge overwrote -termux suffix support
- New upstream code rejected v*-termux tag format
- Prevented version.json creation and update notifications
Affected versions: v0.58.0 through v0.58.3
Termux patches (4 total):
- Patch #1: Browser login fix (termux-open-url)
- Patch #2: RAM optimizations (lto=false, codegen-units=16)
- Patch #3: Auto-update URL (@mmmbuto/codex-cli-termux)
- Patch #4: Auto-update detection (this release)
DioNanos referenced this pull request in DioNanos/codex-termux Nov 21, 2025
Upstream changes (40+ commits):
- New: codex-shell-tool-mcp MCP server
- New: execpolicycheck CLI command
- New: TUI animations toggle feature
- New: Shell timeout increased to 1 hour
- Refactor: execpolicy migration (execpolicy2 -> execpolicy)
- Removed: tiktoken-rs, shell_command feature
- Improved: FreeBSD portability, fuzzy search (8->20 results)
Termux patches verified compatible:
- #1 Browser login (termux-open-url) ✅
- #2 RAM optimizations (lto=false, codegen-units=16) ✅
- #8 Bash execution (sandbox, LD_*, shell detection) ✅
- #9 Auto-update execution ✅
Stats: 195 files changed, +5915 insertions, -2293 deletions
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
DioNanos referenced this pull request in DioNanos/codex-termux Nov 27, 2025
- 8 new tests to validate Termux patches after upstream merge
- Critical tests for Patch #1, #2, #4, #9 (conflicting patches)
- Test auto-update execution, browser login, RAM optimization
- Essential for post-merge validation before npm publish
Test suite v1.2 → v1.3 (90 total tests)
DioNanos referenced this pull request in DioNanos/codex-termux Nov 27, 2025
Merged 61 commits from openai/codex upstream (Nov 21-27, 2025).
✅ ALL TERMUX PATCHES PRESERVED:
- Patch #1: Browser login (termux-open-url) - VERIFIED ✅
- Patch #2: RAM optimization (lto=false) - VERIFIED ✅
- Patch #4: Auto-update URL (DioNanos/codex-termux) - VERIFIED ✅
- Patch #5: Version parser (-termux suffix) - VERIFIED ✅
- Patch #6: NPM package name (@mmmbuto/codex-cli-termux) - VERIFIED ✅
- Patch #9: Auto-update execution (npm install) - VERIFIED ✅
NEW UPSTREAM FEATURES:
- Enterprise skip upgrade config (check_for_update_on_startup)
- Unified exec pruning strategy
- Custom env for unified exec process
- Compaction events
- Thread/turn ID in notifications
- Config management app-server
- Cargo audit workflow + cargo-deny
- NetBSD build fixes
- Windows sandbox enhancements
- Documentation improvements
UPSTREAM CHANGES:
- 232 files changed
- +11247 insertions, -7808 deletions
- New codex-api/ and codex-client/ crates
- Rollout session error improvements
- Apply patch parsing fixes
CONFLICTS RESOLVED:
- README.md: Merged Testing section (Termux) + Documentation links (upstream)
NEXT: Compilation + Category 13 test suite validation
DioNanos referenced this pull request in DioNanos/codex-termux Jan 10, 2026
- Updated workspace version to 0.80.0-termux
- Termux patch #2 (compilation) preserved: lto=false, codegen-units=16
- Termux patch #9 (auto-update execution) preserved in main.rs
- Process hardening removal upstream improves bash execution (patch #8)
Upstream changes (77 commits from rust-v0.79.0):
- Metrics capabilities (otel/metrics modules)
- Requirements/list API
- Thread fork endpoints
- Elevated sandbox onboarding
- Skills explicit invocation via V2 API
- Updated dependencies: lru 0.16.3, zstd added
- Removed codex-process-hardening from Codex CLI
- Updated models.json
DioNanos referenced this pull request in DioNanos/codex-termux Feb 4, 2026
- Set version = "0.95.0"
- Applied Patch #2: lto = false, codegen-units = 16
- Preserved all upstream v0.95.0 workspace members and dependencies
- All Termux patches (#1-#6, #9) verified present
- Next step: Build ARM64 binaries
DioNanos referenced this pull request in DioNanos/codex-termux Feb 18, 2026
Patches applied:
- Patch #1: Browser login fix (termux-open-url)
- Patch #2: Compilation optimizations (lto=false, codegen-units=16)
- Patch #3: Version alignment (0.104.0)
- Patch #4: Auto-update URL (DioNanos/codex-termux)
- Patch #5: Version parser (-termux suffix)
- Patch #6: NPM package name (@mmmbuto/codex-cli-termux)
- Patch #9: Auto-update execution (tui/src/main.rs)
Updated files:
- codex-rs/Cargo.toml: version 0.104.0
- codex-rs/tui/src/main.rs: add update_action execution
- npm-package/package.json: 0.104.0-termux
- patches/README.md: update validated version
Kartvya69 referenced this pull request in Kartvya69/recodex Jul 2, 2026
Upstream added agent_identity_policy (#2) and originator (openai#6) to
ModelClient::new. Update the two fork chat-wire-api test constructors
in client_tests.rs (chat_wire_api_skips_websocket_prewarm,
compaction_with_chat_returns_error) to pass
AgentIdentityAuthPolicy::JwtOnly and "test_originator", matching the
canonical test caller in session/tests.rs.
SammySnake-d added a commit to SammySnake-d/codex-teams that referenced this pull request Jul 14, 2026
 depth)
Deepens real-time monitoring from TURN granularity to TOOL granularity: a
teammate now pushes a kind:progress milestone to the lead the moment it starts a
command / file edit / MCP tool / web search, so the lead can spot drift mid-turn
instead of only at the turn boundary. Event-driven (fires on actual tool use),
never polled, and throttled to <=1 push per 5s so a busy teammate coalescing 50
commands does NOT spam the lead.
Key architecture finding from live testing: the live teammate is the full
interactive TUI (codex teammate), NOT the headless run_teammate_loop (dead code
in the live path). The push therefore lives in the TUI's
handle_item_started_notification (chatwidget/protocol.rs), gated by
teammate_identity_parts() so only teammate processes push. The lead poller
already surfaces plain kind:progress messages as model-visible turns.
- team_coord::send_progress_to_lead: plain model-visible TeammateMessage tagged
Progress/Peer so it arbitrates BELOW corrections (never preempts a fix).
- team_send tool: earlier-added param already carries declared intent.
- Live-proven: scripts/teams_milestone_live_test.sh drives a REAL teammate that
runs a shell_command; the lead inbox receives
'kind=progress role=peer from=worker running: ... echo ...' within 3s.
- Unit tests for formatting + throttle (runner path) still green.
Bump TEAMS_VERSION -> team.6.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ikhdark added a commit to ikhdark/KD4 that referenced this pull request Jul 20, 2026
defims added a commit to defims/lemurclaw that referenced this pull request Jul 20, 2026
…roject 4 final review)
Final whole-subproject review found 2 Important + 1 Minor worth fixing
before declaring subproject 4 done.
Important #1: App.tsx — the composition root (modal host, Ctrl+T, Onboarding
gate wrap, Esc safety-net) had zero test coverage. Added App.test.tsx with
8 integration tests: layout-under-gate, Ctrl+T / Cmd+T / plain-T (negative)
opens transcript, model + theme buttons open their modals, Esc closes, and
single-modal-open enforcement. Mocks useConversation + Onboarding + transport
so App renders without a backend.
To make the integration tests pass, stubbed Element.scrollIntoView in the
test setup (jsdom doesn't implement it; Scrollback calls it on mount). This
unblocks any future test that renders the full tree.
Important openai#2: registerResponseHandler was called in useConversation's mount
effect, but React runs child effects before parent effects — so Onboarding's
sendRequest('getAuthStatus') could theoretically fire before the response
router was installed. It worked only because lib.rs installs a no-op stub
up front AND the backend response takes longer than the next microtask.
Moved the router install to transport.ts module-top-level (idempotent,
guarded for non-window envs) so it's live before any React effect. Kept
registerResponseHandler() as a public idempotent shim; the useConversation
call is now defensive, not load-bearing.
Minor: Composer.tsx stale comment said slash/@-mention/file popups 'land in
subproject 4' — they actually land in subproject 5. Fixed.
Verification: 89/89 tests pass (was 81; +8 App integration), tsc clean,
npm run build succeeds, cargo check clean for lemurclaw-gui.
defims added a commit to defims/lemurclaw that referenced this pull request Jul 20, 2026
Covers the 4 deferred items from subproject 4's final review:
- #1: TopBar cwd + model from ConversationState (reducer captures
thread.cwd + model/rerouted; sendRequest-backed turn/start + thread/resume
feed authoritative ThreadStartResponse/ThreadResumeResponse back via a
synthetic responseMeta action)
- openai#2: AgentPanel real sub-agent data (extract from
collabAgentToolCall.agentsStates into state.subAgents)
- openai#3: full styles.css var-ification (~50 hardcoded colors → theme variables)
Key insight during research: ThreadStartResponse + ThreadResumeResponse both
carry authoritative model + cwd via the Task 4.1 sendRequest channel, so #1b
is clean (not partial as originally thought).
Plan written across 4 Write/Edit calls to avoid the single-Write-too-long
interruption that hit the first attempt (documented in plan §实现备注 openai#8).
defims added a commit to defims/lemurclaw that referenced this pull request Jul 20, 2026
defims added a commit to defims/lemurclaw that referenced this pull request Jul 20, 2026
Follow-up openai#2 to subproject 5-A. Each uninstalled plugin now gets an
'install' button; installed plugins keep 'uninstall'.
Install addresses the plugin's marketplace context (carried into each
flattened PluginRow):
- Local marketplace (PluginMarketplaceEntry.path != null):
plugin/install { marketplacePath, pluginName }
- Remote-only marketplace (path == null):
plugin/install { remoteMarketplaceName, pluginName }
Both install + uninstall refetch the list on success. Auth-required
installs (PluginInstallResponse.appsNeedingAuth) are out of scope — we
just refetch and let the server's installed flag settle.
Test note: getByRole({ name: 'install' }) substring-matches 'uninstall',
so the both-buttons test uses a function matcher for exact equality.
150/150 frontend tests pass; tsc clean.
gabrielbryk added a commit to gabrielbryk/codex that referenced this pull request Aug 3, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this
upgrade's triage:
- Patch openai#2 reworked: upstream split sessions/records.rs into per-agent
readers, so the compact-boundary fix moved to records_cla.rs.
- Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the
error mapping the Slack normalization hooks.
- Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification.
- Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the
UnicodeWidthStr import; use crate::width::display_width instead.
- Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock
companion update.
- 888f445 dropped as a stale lockfile restamp, with a note that the
manifest's base line had drifted from the real merge base.
Rows 16 and 17 squashed from 33 development commits into one commit each;
row 18 left standalone so it stays visible as a drop candidate. utils/pty
kept separate from the statusline feature so it can be upstreamed on its own.
gabrielbryk added a commit to gabrielbryk/codex that referenced this pull request Aug 11, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this
upgrade's triage:
- Patch openai#2 reworked: upstream split sessions/records.rs into per-agent
readers, so the compact-boundary fix moved to records_cla.rs.
- Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the
error mapping the Slack normalization hooks.
- Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification.
- Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the
UnicodeWidthStr import; use crate::width::display_width instead.
- Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock
companion update.
- 888f445 dropped as a stale lockfile restamp, with a note that the
manifest's base line had drifted from the real merge base.
Rows 16 and 17 squashed from 33 development commits into one commit each;
row 18 left standalone so it stays visible as a drop candidate. utils/pty
kept separate from the statusline feature so it can be upstreamed on its own.
gabrielbryk added a commit to gabrielbryk/codex that referenced this pull request Aug 11, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this
upgrade's triage:
- Patch openai#2 reworked: upstream split sessions/records.rs into per-agent
readers, so the compact-boundary fix moved to records_cla.rs.
- Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the
error mapping the Slack normalization hooks.
- Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification.
- Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the
UnicodeWidthStr import; use crate::width::display_width instead.
- Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock
companion update.
- 888f445 dropped as a stale lockfile restamp, with a note that the
manifest's base line had drifted from the real merge base.
Rows 16 and 17 squashed from 33 development commits into one commit each;
row 18 left standalone so it stays visible as a drop candidate. utils/pty
kept separate from the statusline feature so it can be upstreamed on its own.
sekfung pushed a commit to sekfung/codex that referenced this pull request Aug 20, 2026
build(desktop): add CNB pipeline for Codex Desktop (Tauri)
PR-URL: openai#2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tibo-openai@ibigio