Conversation
bolinfest
requested review from
aibrahim-oai,
dylan-hurd-oai and
nornagon-openai
August 19, 2025 19:50
dylan-hurd-oai
approved these changes
Aug 19, 2025
| @@ -139,15 +139,15 @@ jobs: | |||
| # Running `cargo build` from the workspace root builds the workspace using | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Running `cargo build` from the workspace root builds the workspace using | |
| # Running `cargo check` from the workspace root builds the workspace using |
Collaborator
Author
There was a problem hiding this comment.
The comment is correct as is: it is still the case that "Running cargo build from the workspace root builds the workspace using the union of all features from third-party crates."
aibrahim-oai
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ubuntu-24.04 - x86_64-unknown-linux-gnubuild is failing withNo space left on deviceon #2465, so let's get this in first, which should help.Note that
cargo checkshould be faster and use less disk thancargo buildbecause it does not write out the object files.