Skip to content

Use ApiPathString in app-server filesystem permission paths - #28367

Merged
anp-oai merged 10 commits into
mainfrom
codex/app-server-api-path-filesystem
Jun 16, 2026
Merged

Use ApiPathString in app-server filesystem permission paths#28367
anp-oai merged 10 commits into
mainfrom
codex/app-server-api-path-filesystem

Conversation

@anp-oai

@anp-oaianp-oai commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Why

Clients running an app-server on one OS and an exec-server on another OS need to be able to pass sandbox config to app-server that refers to resources on the executor's foreign OS.

What

AbsolutePathBuf can't represent these paths and we don't want users to be exposed to PathUri yet, so this moves the public app-server API to be expressed in terms of ApiPathString.

Stacked on #28165.

  • change app-server v2 filesystem permission paths, including legacy read/write roots, to ApiPathString
  • localize API paths through PathUri when converting into the current native core permission types
  • make path-bearing permission conversions fallible and surface localization failures instead of silently treating malformed grants as ordinary denials
  • propagate conversion failures through app-server and TUI approval handling
  • regenerate the app-server JSON and TypeScript schemas
  • leave migration TODOs on native-path conversions so they can be removed once core permission paths use PathUri

anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
@anp-oai
anp-oai marked this pull request as ready for review June 15, 2026 20:30
@anp-oai

Copy link
Copy Markdown
ContributorAuthor

@codex review

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:84aa89ac79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcodex-rs/tui/src/app/thread_routing.rs
Comment threadcodex-rs/tui/src/chatwidget/protocol_requests.rs
anp-oai added a commit that referenced this pull request Jun 15, 2026
Comment threadcodex-rs/tui/src/app/app_server_requests.rs Outdated
anp-oai added a commit that referenced this pull request Jun 15, 2026
@anp-oai
anp-oaiforce-pushed the codex/app-server-api-path-filesystem branch from bb5eacc to 6d76883CompareJune 15, 2026 23:27
@anp-oai
anp-oaiforce-pushed the codex/app-server-api-path-filesystem branch from 6d76883 to 99424a5CompareJune 15, 2026 23:37
Comment threadcodex-rs/tui/src/app/tests.rs Outdated
Base automatically changed from codex/generic-filesystem-path to mainJune 15, 2026 23:55
@anp-oai
anp-oai requested a review from a team as a code ownerJune 15, 2026 23:55
@anp-oai
anp-oaiforce-pushed the codex/app-server-api-path-filesystem branch from aa9100f to 95b2e85CompareJune 16, 2026 00:50
@anp-oai
anp-oai merged commit ecfe174 into mainJun 16, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/app-server-api-path-filesystem branch June 16, 2026 02:25
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 16, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@anp-oai@pakrym-oai