feat(mcp): per-server startup timeout - #3182
Merged
Merged
Conversation
- Add timeout_ms to McpServerConfig with 10s default when unset - Use per-server timeout for initialize and tools/list; aggregate startup/list errors with captured output and drop failing servers from registry - Introduce ManagedClient to store client and timeout; rename LIST_TOOLS_TIMEOUT to DEFAULT_MCP_SERVER_TIMEOUT - mcp-client: pipe and retain last 20 lines of STDOUT/STDERR; add output_snippet API for diagnostics - Update docs to document timeout_ms with example and options table
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
dolan-openai
commented
Sep 4, 2025
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
dolan-openai
marked this pull request as ready for review
September 4, 2025 19:49
Collaborator
|
I'm going to let @jif-oai take a first crack at this, but two things off the top of my head:
|
dolan-openai
force-pushed
the
dolan-2025-09-04-tool-timeout
branch
from
September 5, 2025 20:54
fee27a0 to
05f282e
Compare
dolan-openai
force-pushed
the
dolan-2025-09-04-tool-timeout
branch
from
September 5, 2025 20:55
05f282e to
917f55c
Compare
jif-oai
approved these changes
Sep 5, 2025
bolinfest
reviewed
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing timeouts on certain, slow mcp server starting up when codex is invoked. Before this change, the timeout was a hard-coded 10s. Need the ability to define arbitrary timeouts on a per-server basis.
Summary of changes