Use ConversationId instead of raw Uuids - #3282
Merged
Merged
Conversation
gpeal
force-pushed
the
gpeal/update-uuid-to-conversationid
branch
7 times, most recently
from
September 8, 2025 01:51
4d3835a to
134e7b3
Compare
gpeal
force-pushed
the
gpeal/update-uuid-to-conversationid
branch
from
September 8, 2025 02:17
134e7b3 to
ab5ee59
Compare
gpeal
marked this pull request as ready for review
September 8, 2025 02:26
gpeal
requested review from
aibrahim-oai,
bolinfest,
easong-openai and
pakrym-oai
September 8, 2025 02:29
aibrahim-oai
approved these changes
Sep 8, 2025
aibrahim-oai
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're trying to migrate from
session_id: Uuidtoconversation_id: ConversationId. Not only does this give us more type safety but it unifies our terminology across Codex and with the implementation of session resuming, a conversation (which can span multiple sessions) is more appropriate.I started this impl on #3219 as part of getting resume working in the extension but it's big enough that it should be broken out.