Skip to content

[codex] add otel tracing - #7844

Merged
apanasenko-oai merged 1 commit into
mainfrom
anton_panasneko_add_tracing
Dec 13, 2025
Merged

[codex] add otel tracing#7844
apanasenko-oai merged 1 commit into
mainfrom
anton_panasneko_add_tracing

Conversation

@apanasenko-oai

@apanasenko-oaiapanasenko-oai commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@apanasenko-oai
apanasenko-oaiforce-pushed the anton_panasneko_add_tracing branch 2 times, most recently from 8d28453 to 48d2cf7CompareDecember 11, 2025 02:09
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/codex-client/src/transport.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/core/src/codex.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/tui2/src/lib.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/app-server/src/lib.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/core/src/codex.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/core/src/codex.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/core/src/codex.rs Outdated
pakrym-oai
pakrym-oai reviewed Dec 11, 2025
View reviewed changes
Comment threadcodex-rs/core/src/tools/parallel.rs
pakrym-oai
pakrym-oai requested changes Dec 11, 2025
View reviewed changes

@pakrym-oaipakrym-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests?
Without tests we'll quickly regress these in one of the refactorings.

@apanasenko-oai
apanasenko-oaiforce-pushed the anton_panasneko_add_tracing branch from 48d2cf7 to 93543fcCompareDecember 12, 2025 03:43
@apanasenko-oai

apanasenko-oai commented Dec 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Should we add tests? Without tests we'll quickly regress these in one of the refactorings.

updated.

@apanasenko-oai
apanasenko-oaiforce-pushed the anton_panasneko_add_tracing branch from 93543fc to a41f8f5CompareDecember 12, 2025 03:48
jif-oai
jif-oai reviewed Dec 12, 2025
View reviewed changes

@jif-oaijif-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Will be so helpful for debugging

Comment threadcodex-rs/core/src/config/types.rs Outdated
Comment threadcodex-rs/core/src/tools/parallel.rs Outdated
Comment threadcodex-rs/core/src/tools/parallel.rs
Comment threadcodex-rs/core/src/tools/parallel.rs
Comment threadcodex-rs/core/src/client.rs Outdated
Comment threadcodex-rs/core/src/codex.rs
Comment threadcodex-rs/core/src/codex.rs
}

fn otel_event_manager(
fn otel_manager(

@jif-oaijif-oaiDec 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test building function seems to be defined in different place. Should we have just one in the otel crate?

@apanasenko-oaiapanasenko-oaiDec 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will refactor this in follow up review, since it's not related to tracing itself.

Comment threadcodex-rs/core/src/default_client.rs Outdated
Comment threadcodex-rs/core/Cargo.toml Outdated
Comment threadcodex-rs/otel/src/otel_manager.rs Outdated
pakrym-oai
pakrym-oai approved these changes Dec 12, 2025
View reviewed changes

@pakrym-oaipakrym-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending @jif-oai's comments.

@apanasenko-oai
apanasenko-oaiforce-pushed the anton_panasneko_add_tracing branch 2 times, most recently from c6eefdc to 93551c6CompareDecember 13, 2025 00:42
@apanasenko-oai
apanasenko-oaiforce-pushed the anton_panasneko_add_tracing branch from 93551c6 to 9e8f98aCompareDecember 13, 2025 00:46
@apanasenko-oai
apanasenko-oai merged commit ad7b9d6 into mainDec 13, 2025
26 checks passed
@apanasenko-oai
apanasenko-oai deleted the anton_panasneko_add_tracing branch December 13, 2025 01:07
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jif-oaijif-oaijif-oai left review comments
@pakrym-oaipakrym-oaipakrym-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apanasenko-oai@pakrym-oai@jif-oai