fix: add aclose() method to AsyncStream for PEP 525 compliance - #2880
Closed
nightcityblade wants to merge 1 commit into
Closed
nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
AsyncStream only exposed close() but not aclose(), causing AttributeError when callers use the standard Python async cleanup convention (e.g. instrumentation libraries calling response.aclose()). Fixes openai#2853
Contributor
Author
|
Gentle ping — this adds the missing aclose() method to AsyncStream for proper PEP 525 async generator cleanup. Happy to address any feedback. |
This was referenced Jul 29, 2026
This was referenced Aug 18, 2026
6 tasks
Contributor
|
Thanks for the contribution, and sorry for the delay! This is now covered by #2854, so I’m closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2853
AsyncStreamonly exposedclose()but notaclose(), causingAttributeErrorwhen callers use the standard Python async cleanup convention (await stream.aclose()).This surfaces in production when instrumentation libraries (e.g. Langfuse) wrap the raw stream and call
aclose()following PEP 525 convention.Fix
Add
aclose()as a thin alias forclose()onAsyncStream, matching the convention used byhttpx.Response,asyncio.StreamWriter, and Python async generators.Changes
src/openai/_streaming.py: Addedaclose()method toAsyncStreamclass (4 lines)