Conversation
AsyncStream exposes close() but not aclose(), causing AttributeError when callers use the standard Python async cleanup convention. This surfaces with instrumentation libraries (e.g. Langfuse) that wrap the raw stream and call aclose(). Fixes openai#2853 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the contribution, and sorry for the delay! This is now covered by #2854, so I’m closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2853
Problem
AsyncStreamexposesclose()but notaclose(), causingAttributeErrorwhen callers use the standard Python async cleanup convention (await stream.aclose()). This surfaces with instrumentation libraries (e.g. Langfuse) that wrap the raw stream.Fix
Added
aclose()as an alias forclose()onAsyncStream, following the standard Python async resource convention (PEP 525, used byasyncio,httpx, etc.). Note thatAsyncStream.close()already internally callsself.response.aclose().This contribution was developed with AI assistance (Claude Code).