Skip to content

Fix indentation in unions with refs - #245

Merged
dbanty merged 1 commit into
openapi-generators:mainfrom
upciti:fix/unexpected-indent-union-with-ref
Nov 20, 2020
Merged

Fix indentation in unions with refs#245
dbanty merged 1 commit into
openapi-generators:mainfrom
upciti:fix/unexpected-indent-union-with-ref

Conversation

@fyhertz

@fyhertzfyhertz commented Nov 19, 2020

Copy link
Copy Markdown
  • Add a query parameter in golden record to test schema with "anyOf": { "$ref": ...}
  • Seems to me that there was some over indenting in union_template.pyi
  • Mypy is unhappy, because in the union_template.pyi the transform macro from sub templates redefines the property, with a different type. How should I fix this?

@codecov

codecovBot commented Nov 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #245 (662e833) into main (fb4787e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## main #245 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 46 46 Lines 1302 1302 =========================================
Hits 1302 1302 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4787e...662e833. Read the comment docs.

@dbanty

Copy link
Copy Markdown
Collaborator

I'm pretty sure #241 fixes this same thing. Can you check out main and try it there to make sure?

@fyhertz
fyhertzforce-pushed the fix/unexpected-indent-union-with-ref branch from d734fcc to 662e833CompareNovember 20, 2020 15:02
@fyhertz

Copy link
Copy Markdown
Author

Problem fixed indeed ! We could still benefit from the additional test case, I can rename the commit if you want, or we can close the pr.

@dbanty
dbanty merged commit c0431c7 into openapi-generators:mainNov 20, 2020
@fyhertz
fyhertz deleted the fix/unexpected-indent-union-with-ref branch May 10, 2023 15:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fyhertz@dbanty