Skip to content

Lower version requirements for python-dateutil in generated client #298 - #299

Merged
dbanty merged 2 commits into
openapi-generators:mainfrom
benchling:issue-298-lower-python-dateutil-version
Jan 14, 2021
Merged

Lower version requirements for python-dateutil in generated client #298#299
dbanty merged 2 commits into
openapi-generators:mainfrom
benchling:issue-298-lower-python-dateutil-version

Conversation

@bowenwr

@bowenwrbowenwr commented Jan 14, 2021

Copy link
Copy Markdown
Contributor

The generated client now features a slightly more permissive version of python-dateutil to reduce dependency conflicts with some other projects. #298

@codecov

codecovBot commented Jan 14, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #299 (43762b4) into main (701ea77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## main #299 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 46 46 Lines 1348 1348 =========================================
Hits 1348 1348

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701ea77...43762b4. Read the comment docs.

@bowenwr

bowenwr commented Jan 14, 2021

Copy link
Copy Markdown
ContributorAuthor

@dbanty I changed it in the templates for the generated client but not in the root pyproject.toml for the project itself. Let me know if you'd rather make it consistent there. Wasn't sure if dependabot would keep bumping it anyway.

@bowenwr

bowenwr commented Jan 14, 2021

Copy link
Copy Markdown
ContributorAuthor

FYI @packyg

dbanty
dbanty requested changes Jan 14, 2021
View reviewed changes
Comment threadCHANGELOG.md Outdated
@bowenwr@dbanty
Update CHANGELOG.md
43762b4
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
@bowenwr
bowenwr requested a review from dbantyJanuary 14, 2021 16:08
@dbanty

dbanty commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

Looks great, I love a nice easy code review in the morning ☺️

@dbanty
dbanty enabled auto-merge (squash) January 14, 2021 16:15
@bowenwr

bowenwr commented Jan 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Looks great, I love a nice easy code review in the morning ☺️

Thanks for your help and being so obliging! 🙌

@dbanty
dbanty merged commit 93723dd into openapi-generators:mainJan 14, 2021
dbanty added a commit that referenced this pull request Jan 16, 2021
@dbanty
docs(changelog): Added entries for#299&#292and ran prettier.
aede9be
@dbantydbanty added this to the 0.8.0 milestone Jan 16, 2021
bowenwr added a commit to benchling/openapi-python-client that referenced this pull request Jan 20, 2021
@bowenwr@dbanty
fix: Lower version requirements for python-dateutil in generated client
3b12217
openapi-generators#298 (openapi-generators#299)
* Lower version requirements for python-dateutil in generated client openapi-generators#298
* Update CHANGELOG.md
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
bowenwr added a commit to benchling/openapi-python-client that referenced this pull request Jan 28, 2021
@bowenwr@dbanty
fix: Lower version requirements for python-dateutil in generated client
981fade
openapi-generators#298 (openapi-generators#299)
* Lower version requirements for python-dateutil in generated client openapi-generators#298
* Update CHANGELOG.md
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
@eli-bl
eli-bl deleted the issue-298-lower-python-dateutil-version branch November 22, 2024 19:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbantydbantydbanty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bowenwr@dbanty