Inheritance support

[nebulon42]

Quite impressed with the toolset you created here.

I was curious about inheritance support so I tried it out with a minimal example:

openapi: 3.0.2
info:
 title: edit me
 version: 1.0.0
paths:
 /nothing:
 description: dummy
 get:
 responses:
 '200':
 description: empty
 content:
 'application/json':
 schema:
 $ref: '#/components/schemas/ChildSchema'
components:
 schemas:
 ParentSchema:
 type: object
 properties:
 parentAttr:
 type: string
 ChildSchema:
 allOf:
 - $ref: '#/components/schemas/ParentSchema'
 - type: object
 properties:
 childAttr:
 type: string

This yields a ChildSchema.java consisting of everything from the parent and child model:

public class ChildSchema {

 @JsonProperty("parentAttr")
 private String parentAttr;

 @JsonProperty("childAttr")
 private String childAttr;

 public String getParentAttr() {
 return parentAttr;
 }

 public void setParentAttr(String parentAttr) {
 this.parentAttr = parentAttr;
 }

 public String getChildAttr() {
 return childAttr;
 }

 public void setChildAttr(String childAttr) {
 this.childAttr = childAttr;
 }

}

Now specifying a discriminator results in inheritance in the generated code (at least for the openapi-generator project):

openapi: 3.0.2
info:
 title: edit me
 version: 1.0.0
paths:
 /nothing:
 description: dummy
 get:
 responses:
 '200':
 description: empty
 content:
 'application/json':
 schema:
 $ref: '#/components/schemas/ChildSchema'
components:
 schemas:
 ParentSchema:
 type: object
 discriminator:
 propertyName: className
 properties:
 parentAttr:
 type: string
 ChildSchema:
 allOf:
 - $ref: '#/components/schemas/ParentSchema'
 - type: object
 properties:
 childAttr:
 type: string

For this a special propertyName of className is used. If I run that in your playground with spring 2021.5 it complains about the property name which is not wrong strictly speaking:
The discriminator 'className' is not a property of this schema (code: 134)
If I run this locally with 2023.1.2 then this does not error but does not generate two classes with one inheriting from each other:

public class ChildSchema {

 @JsonProperty("parentAttr")
 private String parentAttr;

 @JsonProperty("childAttr")
 private String childAttr;

 public String getParentAttr() {
 return parentAttr;
 }

 public void setParentAttr(String parentAttr) {
 this.parentAttr = parentAttr;
 }

 public String getChildAttr() {
 return childAttr;
 }

 public void setChildAttr(String childAttr) {
 this.childAttr = childAttr;
 }

}

Expected result would have been:

public class ParentSchema {

 @JsonProperty("parentAttr")
 private String parentAttr;

 public String getParentAttr() {
 return parentAttr;
 }

 public void setParentAttr(String parentAttr) {
 this.parentAttr = parentAttr;
 }

}

public class ChildSchema extends ParentSchema {

 @JsonProperty("childAttr")
 private String childAttr;

 public String getChildAttr() {
 return childAttr;
 }

 public void setChildAttr(String childAttr) {
 this.childAttr = childAttr;
 }

}

Now this expectation could of course be wrong. My question now would be if this inheritance use case is supported and/or if I would have to do something differently to get the desired result. Thanks.

[hauner]

Thanks. :-)

It does not have any inheritance support. So far I didn't need it. I may look at it, but don't expect it anytime soon. There are a few other things on my todo list.