fix(snapshot): accept reordered columns and prepare 0.16.4 - #136
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(snapshot): accept reordered columns and prepare 0.16.4 This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot refreshes could require table replacement when equivalent SQLite schemas listed their columns in a different order. Rows in the snapshot are JSON objects keyed by name, so this unnecessarily blocks merge imports that must retain local history.
Compare equal, unique column-name sets while preserving the original manifest order and all existing shard/fingerprint checks. Added, removed, renamed, and duplicate columns still require replacement. Extend the real export/import regression to verify reordered columns, updated rows, and preservation of destination-only rows.
Prepare patch release 0.16.4, including the already-landed scheduler pipe-drain and cache-path fixes. Release publication remains owned by the unified workflow.
Validation: regression reproduced against the original implementation; full Go tests and vet passed; independent P0–P2 review clean; actionlint passed. The complete make check release gate passed, including race, deadcode, vulnerability, and release-script tests. PR and landing-head CI provide platform and downstream coverage.