Uh oh!
There was an error while loading. Please reload this page.
Prefetch participant images fixes #311 - #351
Conversation
anupm12
commented
Feb 3, 2019
@Anupam-dagar@ananya-agrawal please review this pr. |
anupm12
commented
Feb 3, 2019
I'm not sure, but I think it works better in Firefox developer edition. |
prateek76
commented
Feb 3, 2019
link |
I'm sorry. I forget everytime 😅 |
prateek76
commented
Feb 3, 2019
@anupm12 i can't see any impovement also in firefox it's taking more time than before |
anupm12
commented
Feb 3, 2019
@prateek76 |
@pradeepgangwar@ananya-agrawal@prateek76 https://stackoverflow.com/questions/41655955/why-are-preload-link-not-working-for-json-requests |
anupm12
commented
Feb 4, 2019
Anupam-dagar
commented
Feb 4, 2019
@pradeepgangwar take a look at it. |
pradeepgangwar
commented
Feb 5, 2019
This is not the correct way to load image and assign. I see that in your script you are appending it in body tag. |
anupm12
commented
Feb 5, 2019
pradeepgangwar
commented
Feb 12, 2019
@anupm12 Sorry for delay 😅 . I got busy with other things and completely forgot about this one. Let me check this. |


Did you read the instructions in README ?
Yes
Solves which issue ?
Fixes#311
Give discription.
Images are now being cached by the browser and the loading is comparatively faster now. All time it takes is to fetch data from json.
I have made a script to fetch the images and prefetched that script using HTML.
Checklist
(To mark the checkboxes use
xwithin the box brackets)Signed the code of conduct.
Have you added yourself to the participants.
Joined opencode zulip server.