Uh oh!
There was an error while loading. Please reload this page.
Allow the user to specify whether they want to use POST or GET for pe… - #97
Conversation
…rforming the OC request to the registry
matteofigus
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think adding a way to force POST is a useful feature, especially in case you have big payloads etc.
Can we handle the scenario where there are more than 1 component and
method=GET? I think in that case, we should probably return with an exception or error, as the GET only allows one component.Can we add some unit or acceptance tests for the various scenarios (empty|GET|POST|GET+multiple components exception)?
Can you update the README for documenting the new
methodparameter?
Thanks!
wsalazar-peakactivity
commented
Mar 26, 2019
Absolutely. I'll get back to you in a few days with an updated PR. Thanks. |
… is set to GET. Update to README file for httpMethod.
wsalazar-peakactivity
commented
Mar 30, 2019
This is not ready for review just yet. I meant to push this to my fork but for some reason it got picked up. |
…rforming the OC request to the registry