Uh oh!
There was an error while loading. Please reload this page.
Update runtime.md - #157
Merged
Merged
Conversation
liangchenye
commented
Sep 8, 2015
MemberAuthor
Clean the original PR #156.. |
vbatts
commented
Sep 8, 2015
Member
LGTM |
Contributor
There was a problem hiding this comment.
Probably no need to add this empty line.
philips
commented
Sep 9, 2015
Contributor
lgtm |
vbatts
commented
Sep 10, 2015
Member
@liangchenye rebase needed for merging |
Add an explicit explanation of the hooks order. Signed-off-by: Liang Chenye <liangchenye@huawei.com>
liangchenye
commented
Sep 10, 2015
MemberAuthor
@vbatts done. |
wking added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Dec 11, 2015
Extend [1,2,3] to avoid: hook 1: spawn ---------------> reaped hook 2: spawn ----------------> reaped hook 3: spawn -----> reaped and explicitly require: hook 1: spawn --> reaped hook 2: spawn --> reaped hook 3: spawn --> reaped Folks who do want parallel execution are free to use a parallelizing wrapper: hook 1: spawn ---------------------------> reaped child 1 -----> reaped child 2 ---------> reaped child 3 ---> reaped Although that cuts both ways (with parallel hooks, folks could always use a single hook with a serializing wrapper). Still, I'd guess most current implementations are already taking the serialized approach, so it makes bundle-author life easier if we are explicit about that. [1]: opencontainers#20 (comment) [2]: opencontainers#156 [3]: opencontainers#157 Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit explanation of the hooks order.
Signed-off-by: Liang Chenye liangchenye@huawei.com