Uh oh!
There was an error while loading. Please reload this page.
Rename State's Root to Bundle - #206
Merged
Merged
Conversation
crosbymichaelforce-pushed
the
bundle-state
branch
from
September 29, 2015 17:39
f71ea55 to
1d05ac4Comparemrunalp
commented
Sep 29, 2015
Contributor
LGTM |
Contributor
There was a problem hiding this comment.
nit: How about BundlePath since Bundle can be interpreted as the name of the bundle.
crosbymichaelforce-pushed
the
bundle-state
branch
from
September 29, 2015 18:43
1d05ac4 to
8ff2dcaComparecrosbymichael
commented
Sep 29, 2015
MemberAuthor
Updated |
MemberAuthor
There was a problem hiding this comment.
what do you mean? i don't see it?
vbatts
commented
Sep 29, 2015
Member
one last nit, and LGTM |
crosbymichaelforce-pushed
the
bundle-state
branch
from
September 29, 2015 19:09
8ff2dca to
a745b1cCompareSigned-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichaelforce-pushed
the
bundle-state
branch
from
September 29, 2015 19:09
a745b1c to
34def3aComparecrosbymichael
commented
Sep 29, 2015
MemberAuthor
@vbatts done |
mrunalp
commented
Sep 29, 2015
Contributor
LGTM. All comments have been addressed. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby crosbymichael@gmail.com