Uh oh!
There was an error while loading. Please reload this page.
use the lifecycle states to define the hooks - #250
Conversation
hqhq
commented
Nov 17, 2015
Lifecycle modification is on going in #231 , this PR needs to be hold on. |
laijs
commented
Nov 18, 2015
The intention of this pr is, as its title said, using the lifecycle states to define the hooks. |
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
vbatts
commented
Nov 20, 2015
This looks fine for the most part. The switch from "exits" -> "stopped" seems to imply the hooks may get triggered before the container has fully ended. Like if the pid(s) are sent signals to terminate, but they hang in a Wait state, would the hooks still get called? |
philips
commented
Nov 25, 2015
This PR is too confusing. "container is started" is confusing: the only way it has meaning is if we agree on a term that isn't "container" for the application process. |
vbatts
commented
Dec 9, 2015
#231 is merged. Please update. |
No description provided.