Uh oh!
There was an error while loading. Please reload this page.
Clarify cgroupsPath to be absolute - #266
Conversation
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
wking
commented
Dec 11, 2015
On Thu, Dec 10, 2015 at 11:54:10PM -0800, Qiang Huang wrote:
I'd understood it to mean “relative to the cgroups mount point
I don't think “relative to an implementation-defined thing” is "cgroupsPath": "myRuntime/myContainer" and just error out if cgroupsPath starts with a slash? Then we |
mrunalp
commented
Dec 16, 2015
I'd prefer it to be specified as an absolute path (internally relative to cgroups path). One reason is that it will be consistent with what one sees in /proc//cgroup. |
wking
commented
Dec 16, 2015
On Wed, Dec 16, 2015 at 10:10:26AM -0800, Mrunal Patel wrote:
I think that “absolute but internally relative to the cgroups mount
+1 for consistency. If this is the consistency we're shooting for |
hqhq
commented
Dec 22, 2015
Close in favor of #270 |
The former description is not accurate, it only says
relative to the cgroups mount point,if the path is absolute, it's easy to understand, but if it's relative, should it still be relative
to the cgroups mount point?
I think we can define it to be only absolute path, or we can also clarify if it's relative,
let implementation define what it would be relative to.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com