Uh oh!
There was an error while loading. Please reload this page.
Appropriately mark optional fields as omitempty - #283
Conversation
Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
hqhq
commented
Dec 25, 2015
LGTM |
arcnmx
commented
Dec 29, 2015
Oh, one other item I forgot about that should be |
hqhq
commented
Dec 30, 2015
@arcnmx Thanks, @jonboulle Can you update for that? Thanks. |
jonboulle
commented
Dec 31, 2015
done On Wed, Dec 30, 2015 at 2:16 AM, Qiang Huang notifications@github.com
|
hqhq
commented
Dec 31, 2015
@jonboulle You need to sign your commit. |
Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
jonboulle
commented
Dec 31, 2015
Sigh. Done. On Thu, Dec 31, 2015 at 12:15 PM, Qiang Huang notifications@github.com
|
hqhq
commented
Jan 2, 2016
Thanks, still LGTM. |
vbatts
commented
Jan 4, 2016
LGTM |
Appropriately mark optional fields as omitempty
Signed-off-by: Jonathan Boulle jonathanboulle@gmail.com
per #282 (comment)