Skip to content

version: include version in produced docs - #406

Merged
vbatts merged 1 commit into
opencontainers:masterfrom
vbatts:version_page
May 2, 2016
Merged

version: include version in produced docs#406
vbatts merged 1 commit into
opencontainers:masterfrom
vbatts:version_page

Conversation

@vbatts

@vbattsvbatts commented Apr 27, 2016

Copy link
Copy Markdown
Member

Fixes#398

This produces a markdown page as a header for the PDF and HTML pages.

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@wking

Copy link
Copy Markdown
Contributor

On Wed, Apr 27, 2016 at 07:54:30AM -0700, Vincent Batts wrote:
“ A .tool/version-doc.go (25)”

This is depressingly large when an inline:

$ sed -n 's/."ociVersion": *"([^"])",/Specification Version:\1/p' config.md

would do the same thing (assuming we update the example 1). But
maybe relying on Go is more portable than relying on sed? On the
other hand, systems that have ‘make’ are likely to have ‘sed’.

Aside from that minor grump, 73ef76d looks good to me.

@crosbymichael

Copy link
Copy Markdown
Member

LGTM

plz rebase

Fixesopencontainers#398
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
vbatts merged commit 4941dba into opencontainers:masterMay 2, 2016
@vbatts
vbatts deleted the version_page branch May 2, 2016 18:12
@wkingwking mentioned this pull request May 7, 2016
Mashimiao pushed a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
Fixesopencontainers#398
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vbatts@wking@crosbymichael