Skip to content

[ Runtime ] Add example with a Windows bundlePath - #460

Closed
RobDolinMS wants to merge 1 commit into
opencontainers:masterfrom
RobDolinMS:patch-5
Closed

[ Runtime ] Add example with a Windows bundlePath#460
RobDolinMS wants to merge 1 commit into
opencontainers:masterfrom
RobDolinMS:patch-5

Conversation

@RobDolinMS

Copy link
Copy Markdown
Collaborator

Adds an example with a Windows bundlePath value

Signed-off-by: Rob Dolin RobDolin@microsoft.com

Adds an example with a Windows bundlePath value
Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
Comment threadruntime.md
{
"ociVersion": "0.2.0",
"id": "oci-container1",
"pid": 4422,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth waiting until #459 settles for this.

And it would be good to get anchor-headers.

@tianontianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon

Copy link
Copy Markdown
Member

Looks like PullApprove claims you're missing Signed-off-by again, although that's not the case....

@mrunalp

Copy link
Copy Markdown
Contributor

@RobDolinMS could you make a trivial change and push again? (like modify the pid)

@mrunalpmrunalp closed this Jan 11, 2017
@mrunalpmrunalp reopened this Jan 11, 2017
@crosbymichaelcrosbymichael self-assigned this Feb 2, 2017
@crosbymichael

Copy link
Copy Markdown
Member

@RobDolinMS when you have time please rebase your PRs and make sure your sign off is correct. Feel free to reopen when they have been updated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@RobDolinMS@tianon@mrunalp@crosbymichael@wking