Uh oh!
There was an error while loading. Please reload this page.
specs-go/config: fix required items type - #586
Conversation
wking
commented
Sep 30, 2016
via email
125b879 looks good to me. The associated JSON Schemas need
'required' entries for these fields as well, but that can happen in a
follow-up PR if you don't want to handle it here. |
Mashimiao
commented
Oct 26, 2016
ping @opencontainers/runtime-spec-maintainers |
cyphar
commented
Oct 26, 2016
Looks fine to me, but doesn't this need a rebase after the aggressive namespacing patch? |
LGTM |
hqhq
commented
Oct 27, 2016
Needs rebase but why there is no conflict detect? |
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
125b879 to
ef9ce84Comparerebased |
LGTM |
Mashimiao
commented
Oct 31, 2016
Ah, that's my fault... fixed. |
| type LinuxPids struct { | ||
| // Maximum number of PIDs. Default is "no limit". | ||
| Limit *int64 `json:"limit,omitempty"` | ||
| Limit int64 `json:"limit"` |
There was a problem hiding this comment.
Isn't nil here meaning no limit?
There was a problem hiding this comment.
@crosbymichael, nil is not allowed because limit is required.
@stevvooe, I expect 0 should be illegal. Can you file a separate PR to require strictly positive value?
There was a problem hiding this comment.
From the kernel side, 0 is functionally identical to 1 (because you can join a cgroup even if it has a limit of 0).
LGTM |
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com
These items are defined as
required, I'm not sure the history, but I think they should not be pointer type.