Skip to content

Forbid duplicated rlimits with same type - #607

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
hqhq:handle_duplicated_rlimits
Jan 11, 2017
Merged

Forbid duplicated rlimits with same type#607
mrunalp merged 1 commit into
opencontainers:masterfrom
hqhq:handle_duplicated_rlimits

Conversation

@hqhq

@hqhqhqhq commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

Alternative of #583 , as what we do for namespaces
in #597 .

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

Alternative of opencontainers#583 , as what we do for `namespaces`
in opencontainers#597 .
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@wking

wking commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

On Wed, Nov 02, 2016 at 07:15:57PM -0700, Qiang Huang wrote:

Alternative of #583 , as what we do for namespaces
in #597 .

The concern with using objects for namespaces was the path handling
[1](and I still think it would have been better to use an object
there [2]). But we require at least one limit for rlimit entries
(otherwise what's the point?), so I don't see a reason to not go
with an object for rlimits.

@wking

wking commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

On Wed, Nov 02, 2016 at 08:36:27PM -0700, W. Trevor King wrote:

But we require at least one limit for rlimit entries (otherwise
what's the point?)…

Actually, we don't. But an rlimit entry with neither hard nor soft is
a no-op, while in #598 we needed to distinguish between no-op and
“create a new namespace”. So I think my initial “so I don't see a
reason to not go with an object for rlimits” still stands.

@hqhq

hqhq commented Nov 3, 2016

Copy link
Copy Markdown
ContributorAuthor

@wking I still don't see the problem of using array here after we fix the duplicated type issue.

@wking

wking commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

It's nothing insurmountable, but add-or-replace and removal are much easier with objects. In #597 I linked to this hoop jumping you need to support then for arrays.

@crosbymichael

crosbymichael commented Nov 28, 2016

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

2 similar comments
@dqminh

dqminh commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@mrunalp

mrunalp commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@mrunalp
mrunalp merged commit 985b97a into opencontainers:masterJan 11, 2017
@hqhq
hqhq deleted the handle_duplicated_rlimits branch January 12, 2017 01:14
@vbattsvbatts mentioned this pull request Jan 27, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hqhq@wking@crosbymichael@dqminh@mrunalp