Skip to content

specs-go/config: add Intel RDT/CAT Linux support - #630

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
xiaochenshen:rdt-cat-resctrl-cgroup-v1
Mar 10, 2017
Merged

specs-go/config: add Intel RDT/CAT Linux support#630
mrunalp merged 1 commit into
opencontainers:masterfrom
xiaochenshen:rdt-cat-resctrl-cgroup-v1

Conversation

@xiaochenshen

@xiaochenshenxiaochenshen commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

Add support for Intel Resource Director Technology (RDT) / Cache Allocation
Technology (CAT). Add L3 cache resource constraints in Linux-specific
configuration.

This is the prerequisite of this runc proposal:
opencontainers/runc#433

For more information about Intel RDT/CAT, please refer to:
opencontainers/runc#433

Signed-off-by: Xiaochen Shen xiaochen.shen@intel.com

@xiaochenshen
xiaochenshenforce-pushed the rdt-cat-resctrl-cgroup-v1 branch 3 times, most recently from 50bf471 to 80ba92fCompareNovember 21, 2016 16:10
@xiaochenshen

xiaochenshen commented Nov 21, 2016

Copy link
Copy Markdown
ContributorAuthor

This PR will obsolete #267 for the change of Intel RDT/CAT kernel interface.

This was referenced Nov 21, 2016
Closed
Closed
@RobDolinMS

RobDolinMS commented Jan 11, 2017

Copy link
Copy Markdown
Collaborator

@xiaochenshen Is it OK to hold-off on this until v1.1 ?

@RobDolinMSRobDolinMS added this to the 1.1.0 milestone Jan 11, 2017
@xiaochenshen

xiaochenshen commented Jan 12, 2017

Copy link
Copy Markdown
ContributorAuthor

@RobDolinMS What is the plan or schedule of v1.1?
This is the dependent PR of opencontainers/runc#1198, and it is part of opencontainers/runc#433. I am fine to hold-off this PR until the issues in opencontainers/runc#1198 are addressed.

@xiaochenshen
xiaochenshenforce-pushed the rdt-cat-resctrl-cgroup-v1 branch 4 times, most recently from c3772a6 to bc14fe0CompareJanuary 17, 2017 21:28
@xiaochenshen
xiaochenshenforce-pushed the rdt-cat-resctrl-cgroup-v1 branch 2 times, most recently from 3d7cb94 to 59c61bdCompareMarch 8, 2017 07:13
crosbymichael
crosbymichael reviewed Mar 8, 2017
View reviewed changes
Comment threadconfig-linux.md Outdated

"linux": {
"resources": {
"intelRdt": {

@crosbymichaelcrosbymichaelMar 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We think this should not be part of resources and should be added inside the linux struct, not resources.

Resources only contains cgroup information for us.

@crosbymichaelcrosbymichaelMar 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, we should be good to merge this in.

@xiaochenshenxiaochenshenMar 9, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crosbymichael@mrunalp Thank you for code review.
I will work on this together with opencontainers/runc#1279

@xiaochenshen
specs-go/config: add Intel RDT/CAT Linux support
73a6002
Add support for Intel Resource Director Technology (RDT) / Cache Allocation
Technology (CAT). Add L3 cache resource constraints in Linux-specific
configuration.
This is the prerequisite of this runc proposal:
opencontainers/runc#433
For more information about Intel RDT/CAT, please refer to:
opencontainers/runc#433
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
@xiaochenshen
xiaochenshenforce-pushed the rdt-cat-resctrl-cgroup-v1 branch from 59c61bd to 73a6002CompareMarch 10, 2017 09:54
@xiaochenshen

xiaochenshen commented Mar 10, 2017

Copy link
Copy Markdown
ContributorAuthor

@crosbymichael
To address your suggestion in #630 (review):
IntelRdt struct has been moved out of Resources and inside Linux now.

The PR opencontainers/runc#1279 has been updated accordingly.

@xiaochenshenxiaochenshen mentioned this pull request Mar 10, 2017
Merged
@crosbymichael

crosbymichael commented Mar 10, 2017•
edited by caniszczyk
Loading

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

1 similar comment
@mrunalp

mrunalp commented Mar 10, 2017•
edited by caniszczyk
Loading

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@mrunalp
mrunalp merged commit 76159da into opencontainers:masterMar 10, 2017
@vbatts

vbatts commented Mar 13, 2017

Copy link
Copy Markdown
Member

So this will still depend on CONFIG_INTEL_RDT_A in the kernel, which defaults to Nhttp://www.cateee.net/lkddb/web-lkddb/INTEL_RDT_A.html

@xiaochenshen

xiaochenshen commented Mar 13, 2017

Copy link
Copy Markdown
ContributorAuthor

@vbatts
From my understanding, it doesn't matter if the kernel config is enabled or not by default. Users can change the kernel config when they want to enable the feature in kernel when the hardware platform supports Intel RDT/CAT.

And also the case will be handled in opencontainers/runc#1279 when hardware or kernel doesn't support Intel RDT/CAT.

@vbattsvbatts mentioned this pull request May 19, 2017
Closed
@vbattsvbatts mentioned this pull request Jul 5, 2017
Merged
zhouhao3 pushed a commit to zhouhao3/runtime-spec that referenced this pull request Jul 11, 2017
zhouhao
config-linux: add intelRdt field
98fbee8
Fixopencontainers#630
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3zhouhao3 mentioned this pull request Jul 11, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichaelcrosbymichaelcrosbymichael left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

(Outdated)

Development

Successfully merging this pull request may close these issues.

5 participants

@xiaochenshen@RobDolinMS@crosbymichael@mrunalp@vbatts