Skip to content

Remove uid/gid mapping limit depend on kernel - #693

Merged
crosbymichael merged 1 commit into
opencontainers:masterfrom
hqhq:dont_limit_mapping
Feb 22, 2017
Merged

Remove uid/gid mapping limit depend on kernel#693
crosbymichael merged 1 commit into
opencontainers:masterfrom
hqhq:dont_limit_mapping

Conversation

@hqhq

@hqhqhqhq commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

Comment threadconfig-linux.md Outdated

The runtime SHOULD NOT modify the ownership of referenced filesystems to realize the mapping.
There is a limit of 5 mappings which is the Linux kernel hard limit.
Note that there might be a limit of mapping entries by the [kernel][user-namespaces].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ... in the Linux kernel.

@crosbymichael

crosbymichael commented Feb 22, 2017

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

Comment threadconfig-linux.md Outdated

The runtime SHOULD NOT modify the ownership of referenced filesystems to realize the mapping.
There is a limit of 5 mappings which is the Linux kernel hard limit.
Note that there might be a limit of mapping entries by the [kernel][user-namespaces].

@mikebrowmikebrowFeb 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The number of mapping entries MAY be limited by the [kernel][user-namespaces].

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq
hqhqforce-pushed the dont_limit_mapping branch from d8818db to a5c4e91CompareFebruary 22, 2017 22:43
@hqhq

hqhq commented Feb 22, 2017

Copy link
Copy Markdown
ContributorAuthor

Updated.

@mrunalp

mrunalp commented Feb 22, 2017

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael

crosbymichael commented Feb 22, 2017

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

@crosbymichael
crosbymichael merged commit 3f5078d into opencontainers:masterFeb 22, 2017
@hqhq
hqhq deleted the dont_limit_mapping branch February 22, 2017 23:03
@vbattsvbatts mentioned this pull request Mar 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hqhq@crosbymichael@mrunalp@mikebrow