Uh oh!
There was an error while loading. Please reload this page.
README: E.123 number for meeting call - #748
Merged
Merged
Conversation
And fix a period/paren swap. The period/paren swap and contry-code addition both bring the local version more in line with the image-spec version [1] and seem like good changes. I've diverged from the image-spec version by using space separation in the phone number instead of hyphens. From E.123 [2,3]: 9.1 Grouping of digits in a telephone number [5] should be accomplished by means or spaces [6] unless an agreed upon explicit symbol (e.g. hyphen) is necessary for procedural purposes. Only spaces should be used in an international number. [1]: https://github.com/opencontainers/image-spec/blob/v1.0.0-rc5/README.md#weekly-call [2]: http://www.itu.int/rec/T-REC-E.123/en [3]: https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-E.123-200102-I!!PDF-E&type=items Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
LGTM |
1 similar comment
Member
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix a period/paren swap. The period/paren swap and contry-code addition both bring the local version more in line with the image-spec version and seem like good changes.
I've diverged from the image-spec version by using space separation in the phone number instead of hyphens. From E.123: