Skip to content

config-linux: RFC 2119 wording for oomScoreAdj - #781

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
wking:oomScoreAdj-rfc-2119
May 9, 2017
Merged

config-linux: RFC 2119 wording for oomScoreAdj#781
mrunalp merged 1 commit into
opencontainers:masterfrom
wking:oomScoreAdj-rfc-2119

Conversation

@wking

@wkingwking commented Apr 26, 2017

Copy link
Copy Markdown
Contributor

The previous wording hinted at, but did not require, this setting to be implemented via oom_score_adj. With the new wording, when proc is mounted at /proc, the container process can check this value by looking at /proc/self/oom_score_adj.

Part of #746.

Comment threadconfig-linux.md Outdated
For more information, see [the proc filesystem documentation section 3.1][procfs].
* **`oomScoreAdj`** *(int, OPTIONAL)* adjusts the oom-killer score in `[pid]/oom_score_adj` for the container process's `[pid]` in a [proc pseudo-filesystem][procfs].
If `oomScoreAdj` is set, the runtime MUST set `oom_score_adj` to the given value.
If `oomScoreAdj` is not set, the runtime MUST not change the value of `oom_score_adj`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/MUST not/MUST NOT

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with e7fdcb8e9a39e7, which also rebases onto master.

@wking
wkingforce-pushed the oomScoreAdj-rfc-2119 branch from e7fdcb8 to e9a39e7CompareMay 9, 2017 16:28
The previous wording hinted at, but did not require, this setting to
be implemented via oom_score_adj. With the new wording, when proc is
mounted at /proc, the container process can check this value by
looking at /proc/self/oom_score_adj.
Signed-off-by: W. Trevor King <wking@tremily.us>
@crosbymichael

crosbymichael commented May 9, 2017

Copy link
Copy Markdown
Member

LGTM

Approved with PullApprove

1 similar comment
@mrunalp

mrunalp commented May 9, 2017

Copy link
Copy Markdown
Contributor

LGTM

Approved with PullApprove

@mrunalp
mrunalp merged commit 01ec62d into opencontainers:masterMay 9, 2017
@wking
wking deleted the oomScoreAdj-rfc-2119 branch May 9, 2017 23:49
@vbattsvbatts mentioned this pull request Jul 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wking@crosbymichael@mrunalp@hqhq