Uh oh!
There was an error while loading. Please reload this page.
Windows: Add IgnoreFlushesDuringBoot - #816
Merged
Merged
Conversation
lowenna
commented
May 15, 2017
ContributorAuthor
Added field to |
Member
LGTM |
mrunalp
approved these changes
May 18, 2017
mrunalp
commented
May 18, 2017
Contributor
Needs rebase. |
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
commented
May 23, 2017
ContributorAuthor
Rebased. |
Member
LGTM (redux) |
TomSweeneyRedHat
commented
May 23, 2017
LGTM |
Contributor
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Similar to #814, the Windows implementation of the docker daemon still passes a number of fields out of band from the OCI runtime spec. This PR addresses the IgnoreFlushesDuringBoot field by adding it to the runtime spec. https://github.com/moby/moby/blob/master/libcontainerd/client_windows.go#L156-L159