Uh oh!
There was an error while loading. Please reload this page.
config-schema: Optimize code - #886
Merged
Merged
Conversation
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
zhouhao3force-pushed
the
config-shchema-fix
branch
from
July 11, 2017 03:11
d31aca6 to
ec99788Comparewking
approved these changes
Jul 11, 2017
TomSweeneyRedHat
commented
Jul 11, 2017
LGTM |
zhouhao3
commented
Aug 1, 2017
Author
Member
LGTM |
wking
commented
Aug 2, 2017
via email
Contributor
I see @hqhq added this to the 1.1.0 milestone back on 2017-07-10 [1]
(and that's now the “1.Y.0” milestone [2]). However, this PR looks
like a pure refactoring, with no impact on any possible consumers, so
it could land in a patch release (vs. a 1.1.0 minor release). Can we
move it to the v1.0.Z milestone [3] (which @crosbymichael may have
created yesterday for [4])?
[1]: #886 (comment)
[2]: https://github.com/opencontainers/runtime-spec/milestone/9
[3]: https://github.com/opencontainers/runtime-spec/milestone/16
[4]: #889 (comment) |
Contributor
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com