Uh oh!
There was an error while loading. Please reload this page.
Add security section - #89
Conversation
There was a problem hiding this comment.
Probably a good time to migrate these to the new Markdown paragraph format (#82).
wking
commented
Jul 30, 2015
On Thu, Jul 30, 2015 at 01:46:35PM -0700, Mrunal Patel wrote:
I think you meant opencontainers/runc#70. I realize this spec isn't going to be a tutorial on container For example, the ‘3’ value for the |
mrunalp
commented
Jul 30, 2015
@wking Yeah, I will flesh out the Seccomp section some more. |
philips
commented
Aug 5, 2015
I like adding the apparmor, selinux, seccomp and capabilities stuff but I don't see any reason to group them in a security section. rlimits may be thought of as a security mechanism to avoid denial-of-service to the rest of the system, for example. |
d3c8ffc to
8d3488eComparemrunalp
commented
Aug 5, 2015
Got rid of the separate Security struct. |
philips
commented
Aug 6, 2015
Overall this change makes sense to me. |
There was a problem hiding this comment.
There are two seccomp.h that are visible to users. One is exported by linux kernel and the other is defined by libseccomp. I think we should mention libseccomp?
mrunalp
commented
Aug 6, 2015
@lizf-os Updated to mention that we use the header from libseccomp. |
LK4D4
commented
Aug 6, 2015
@mrunalp IIRC we also have |
mrunalp
commented
Aug 6, 2015
@LK4D4 Yes, I think we should probably add that as well. I think I will do a follow-on PR for that. |
vbatts
commented
Aug 7, 2015
overall looks fine. rebase needed though. |
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
mrunalp
commented
Aug 7, 2015
Rebased. |
vbatts
commented
Aug 7, 2015
LGTM |
1 similar comment
crosbymichael
commented
Aug 7, 2015
LGTM |
This is WIP for adding security settings as discussed in the meeting.
The settings are based on security profiles in nsinit and Seccomp configuration in opencontainers/runc#70