Skip to content

Release v1.0.0 - #893

Merged
vbatts merged 3 commits into
masterfrom
bump-version
Jul 19, 2017
Merged

Release v1.0.0#893
vbatts merged 3 commits into
masterfrom
bump-version

Conversation

@vbatts

@vbattsvbatts commented Jul 12, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@wking

wking commented Jul 12, 2017 via email

Copy link
Copy Markdown
Contributor

wkingand others added 3 commits July 12, 2017 19:28
@wking@vbatts
ChangeLog: Document changes since v1.0.0-rc6
eac58a4
Through 96de01b (Merge pull request #897 from crosbymichael/pids,
2017-07-12).
Signed-off-by: W. Trevor King <wking@tremily.us>
@vbatts
version: release v1.0.0
02137cd
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
version: bump master back to -dev
84ba019
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
wking
wking reviewed Jul 12, 2017
View reviewed changes
Comment threadspecs-go/version.go

// VersionDev indicates development branch. Releases will be empty string.
VersionDev = "-rc6-dev"
VersionDev = "-dev"

@wkingwkingJul 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6. I'm not sure how we want to handle the post-1.0 world where it's not clear what release we're working on (2.0.0-rc1? 1.1.0-rc1? 1.0.1-rc1?) I'd guess master will most likely target 1.1.0-rc1, so maybe you want to setup 1.1.0-rc1-dev in the tip commit of this PR?

@wkingwkingJul 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6.

Oops, that's not right, since this PR is based on a post-rc6 master using 1.0.0-rc6-dev. I think I was confused by pre-release markers sorting earlier in SemVer. So this commit is fine (since we don't care about SemVer sorting between releases), and sorry for the noise.

@tianon

tianon commented Jul 13, 2017•
edited by caniszczyk
Loading

Copy link
Copy Markdown
Member

LGTM (redux)

Approved with PullApprove

@vbatts

vbatts commented Jul 19, 2017

Copy link
Copy Markdown
MemberAuthor

This needs another LGTM by tomorrow. 😍

@vbatts

vbatts commented Jul 19, 2017

Copy link
Copy Markdown
MemberAuthor

@opencontainers/runtime-spec-maintainers ping

@mrunalp

mrunalp commented Jul 19, 2017•
edited by vbatts
Loading

Copy link
Copy Markdown
Contributor

LGTM

@vbatts

vbatts commented Jul 19, 2017

Copy link
Copy Markdown
MemberAuthor

weird. Not sure why pullapprove is not jiving with that LGTM

@caniszczyk

caniszczyk commented Jul 19, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM weird, I'll kick PA again

Approved with PullApprove

@vbatts
vbatts merged commit 337efca into masterJul 19, 2017
@vbatts
vbatts deleted the bump-version branch July 19, 2017 20:01
@vbattsvbatts mentioned this pull request Sep 8, 2017
Merged
@opencontainersopencontainers locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@wkingwkingwking left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vbatts@wking@tianon@mrunalp@caniszczyk