Skip to content

Implementations page - #93

Merged
mrunalp merged 1 commit into
opencontainers:masterfrom
vbatts:implementations-page
Aug 7, 2015
Merged

Implementations page#93
mrunalp merged 1 commit into
opencontainers:masterfrom
vbatts:implementations-page

Conversation

@vbatts

Copy link
Copy Markdown
Member

Adding an implementations page.

Comment threadimplementations.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“OCF” → “OCI”.

@vbatts
vbattsforce-pushed the implementations-page branch from 4d6af80 to a4645a8CompareAugust 4, 2015 18:01
@vbatts

Copy link
Copy Markdown
MemberAuthor

updated. PTAL

Comment threadimplementations.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line.

@wking

wking commented Aug 4, 2015

Copy link
Copy Markdown
Contributor

On Tue, Aug 04, 2015 at 11:01:31AM -0700, Vincent Batts wrote:

updated. PTAL

I added a few more pedantic comments. But I like this PR, and am fine
with it landing in any form with ≥ it's current level of polish ;).

@vbatts
vbattsforce-pushed the implementations-page branch from a4645a8 to 55703e1CompareAugust 4, 2015 18:18
@vbatts

Copy link
Copy Markdown
MemberAuthor

Updated (again ;-). PTAL

@crosbymichael

Copy link
Copy Markdown
Member

LGTM

@mrunalp

Copy link
Copy Markdown
Contributor

Maybe squash :)

Comment threadimplementations.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just “Implementations” here? The fact that we're talking about this specification should be clear from the context.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

On Tue, Aug 4, 2015 at 2:48 PM, Mrunal Patel notifications@github.com
wrote:

In implementations.md
#93 (comment):

@@ -0,0 +1,13 @@
+# Implementations of Container Specification

+1


Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/93/files#r36226600.

@vbatts
vbattsforce-pushed the implementations-page branch from 55703e1 to b249fc7CompareAugust 4, 2015 18:53
@vbatts

Copy link
Copy Markdown
MemberAuthor

done

On Tue, Aug 4, 2015 at 2:37 PM, Mrunal Patel notifications@github.com
wrote:

Maybe squash :)


Reply to this email directly or view it on GitHub
#93 (comment).

@zenlint

Copy link
Copy Markdown
Contributor

I newed a issuse to talk about How to do bundle compatibility test? #78
Expect anyone who are convenience to give some suggestion, thanks.

@wking

wking commented Aug 5, 2015

Copy link
Copy Markdown
Contributor

See also the discussion that lead to this PR (which also has a
discussion about whether or not this GitHub organization should
contain any implementation repositories):
https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/Tjq5QJ_eez0

In case that link dies, or folks want to look up the conversation in
their local mail archives, here's some information from the message
spawning that thread:

Date: Mon, 3 Aug 2015 16:20:04 +0800
Message-ID: CAHKD89TqBQvbcdvwt-g3J--sDyq=P50qi6CytokNJznVsei7YQ@mail.gmail.com
Subject: Contribute to OCI
From: Thibault Bronchain
To: dev@opencontainers.org

@liangchenye

Copy link
Copy Markdown
Member

Hi @philips , we are testing docker, rkt (and will test other runtimes which implement appc spec).
The rkt testing is on going, we plan to ship a first 0.1 version on 8.15th.

@laijs

laijs commented Aug 6, 2015

Copy link
Copy Markdown
Contributor

huawei-openlab/ocp-testing should be changed to huawei-openlab/oct

LGTM

@vbatts
vbattsforce-pushed the implementations-page branch from b249fc7 to 62cc442CompareAugust 7, 2015 15:15
@vbatts

Copy link
Copy Markdown
MemberAuthor

updated. PTAL

Comment threadimplementations.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph should be re-wrapped to follow #82.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

On Fri, Aug 7, 2015 at 12:15 PM, W. Trevor King notifications@github.com
wrote:

In implementations.md
#93 (comment):

@@ -0,0 +1,18 @@
+# Implementations
+
+The following sections link to associated projects, some of which are
+maintained by the OCI and some of which are maintained by external
+organizations. If you know of any associated projects that are not listed
+here, please file a pull request adding a link to that project.

This paragraph should be re-wrapped to follow #82
#82.


Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/93/files#r36534450.

@wkingwkingAug 7, 2015 via email

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbatts
vbattsforce-pushed the implementations-page branch from 62cc442 to b3ebf84CompareAugust 7, 2015 17:18
@mrunalp

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@philips

Copy link
Copy Markdown
Contributor

LGTM

mrunalp pushed a commit that referenced this pull request Aug 7, 2015
@mrunalp
mrunalp merged commit 5eec1fb into opencontainers:masterAug 7, 2015
@vbatts
vbatts deleted the implementations-page branch September 10, 2015 14:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@vbatts@wking@crosbymichael@mrunalp@zenlint@liangchenye@laijs@philips