Consider adding a new maintainer

[caniszczyk]

Ma Shimiao (mashimiao.fnst@cn.fujitsu.com) has done quite a bit of work so far!

https://github.com/opencontainers/runtime-tools/commits?author=Mashimiao

cc: @mrunalp

[mrunalp]

👍 We can update the existing maintainer list and then open another PR as @wking suggested.

[stephenrwalli]

So as Chris isn't himself a maintainer, should an existing maintainer set up the PR to add Ma Shimiao per the rules [1] to start the 5-day voting period?

[1] https://github.com/opencontainers/project-template/blob/52dbb39db883d7eeacf62865b028c4154578e5c3/MAINTAINERS_GUIDE.md#how-are-maintainers-added

[wking]

On Tue, Oct 11, 2016 at 01:14:58PM -0700, Stephen Walli wrote:

So as Chris isn't himself a maintainer, should an existing
maintainer set up the PR to add Ma Shimiao per the rules 1 to
start the 5-day voting period?

1 https://github.com/opencontainers/project-template/blob/52dbb39db883d7eeacf62865b028c4154578e5c3/MAINTAINERS_GUIDE.md#how-are-maintainers-added

I don't actually see anything in there about needing an existing
maintainer to sponsor, unless it is covered by [1](in which case the
wording should be made more explicit, because the MAINTAINERS_GUIDE
wording predates GOVERNANCE). I'd submit a project-template PR to
make the “anyone can (or can't?) sponsor a new maintainer” bit
explicit, but there's currently a backlog of project-template PRs 2.

Looking at previous examples, @cyphar nominated himself in
opencontainers/runc#503. So I expect it's fine for anyone to file the
PR until we have clearer wording in the MAINTAINERS_GUIDE.

[wking]

On Tue, Oct 11, 2016 at 01:23:48PM -0700, W. Trevor King wrote:

I'd submit a project-template PR to make the “anyone can (or can't?)
sponsor a new maintainer” bit explicit, but there's currently a
backlog of project-template PRs [2].

Actually, it looks like I've already submitted a project-template PR
that (among other things) explicitly ties maintainer addition to
GOVERNANCE 1.

[liangchenye]

+1 for 'Adding Ma Shimiao'.

Also @wking has done lots lots of work so far.
Hi @wking, would like to be a maintainer?

I suggest to add both of them. @mrunalp @caniszczyk

[wking]

On Tue, Oct 11, 2016 at 07:36:26PM -0700, 梁辰晔 (Liang Chenye) wrote:

Also @wking has done lots lots of work so far.
Hi @wking, would like to be a maintainer?

9 maintainers inherited from runtime-spec plus @Mashimiao and
@liangchenye is probably enough hands at the wheel ;). Especially
since I'd prefer fairly different tracks than the current approaches
for both config and runtime validation [1,2]. I'm happy to keep
contibuting as a non-maintainer to avoid bogging down
consensus-forming with my opinions.

[mrunalp]

@caniszczyk Could you setup @liangchenye and @Mashimiao with maintainer privileges on this repo now that they have been added to the MAINTAINER list?

[caniszczyk]

@mrunalp done, I added them to @opencontainers/runtime-tools-maintainers pending they accept the invite

[mrunalp]

Thanks!

On Oct 21, 2016, at 8:44 AM, Chris Aniszczyk notifications@github.com wrote:

@mrunalp done, I added them to @opencontainers/runtime-tools-maintainers pending they accept the invite

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.