Uh oh!
There was an error while loading. Please reload this page.
generate: fix capability.List() for cap_last_cap not exist - #157
Conversation
wking
commented
Jul 27, 2016
via email
Dup of the just-merged #138? |
66cb9db to
d326c89CompareMashimiao
commented
Jul 28, 2016
@wking It seems part of same, but I don't think is a dup. |
wking
commented
Jul 28, 2016
On Wed, Jul 27, 2016 at 06:13:08PM -0700, Ma Shimiao wrote:
Ah, I see that with 3334d03 → d326c89 you've put this on top of master func LastCap() capability.Cap { That way the hack is isolated / DRY. And it would let us add a guard We can probably move those LastCap calls inside the g.HostSpecific |
wking
commented
Jul 28, 2016
via email
And all of my above suggestions are for patching around gocapability
in ocitools for older kernels. A better fix would be to PR
syndtr/gocapability with the additional old-kernel heurstics so you
could guess at CAP_LAST_CAP in these cases. These approaches don't
have to be mutually exclusive if we want to land the RHEL6 workaround
here while we wait for the upstream PR to cook. |
Signed-off-by: masm <mashimiao.fnst@cn.fujitsu.com>
d326c89 to
f7df9c7CompareMashimiao
commented
Jul 28, 2016
@wking already collected all hack together. |
wking
commented
Jul 28, 2016
mrunalp
commented
Jul 28, 2016
LGTM |
Signed-off-by: masm <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0-rc1 from f7df9c7opencontainers#157 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: masm <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from f7df9c7opencontainers#157 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: masm mashimiao.fnst@cn.fujitsu.com