Uh oh!
There was an error while loading. Please reload this page.
sort options list by letter - #204
Merged
Merged
Conversation
wking
commented
Sep 8, 2016
via email
Contributor
cbc3dac looks good to me. |
initlove
commented
Sep 11, 2016
LGTM (and so the later PR should also care about this) |
Mashimiaoforce-pushed
the
fix-sort-options-list
branch
from
September 22, 2016 02:10
cbc3dac to
ae5e68dCompareMashimiao
commented
Sep 22, 2016
Author
PR updated. |
liangchenye
commented
Oct 9, 2016
Member
+1 for this. |
mrunalp
commented
Oct 11, 2016
Contributor
Looks good but needs rebase. |
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiaoforce-pushed
the
fix-sort-options-list
branch
from
October 12, 2016 01:33
ae5e68d to
6ea3464CompareMashimiao
commented
Oct 12, 2016
Author
@mrunalp rebased |
mrunalp
commented
Oct 12, 2016
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com
After this, users can be more easier to find options