Uh oh!
There was an error while loading. Please reload this page.
generate: add OOM Killer disable support - #207
Merged
mrunalp merged 1 commit intoOct 11, 2016
Merged
Conversation
Mashimiaoforce-pushed
the
generate-add-oom-killer-support
branch
from
September 9, 2016 06:19
fe9f3c9 to
b9f4a29Compareliangchenye
commented
Sep 11, 2016
Member
LGTM |
| } | ||
| if context.IsSet("oom-kill-disable") { | ||
| g.SetLinuxResourcesDisableOOMKiller(context.Bool("oom-kill-disable")) |
Contributor
There was a problem hiding this comment.
Follow the spec ordering and use --disable-oom-killer?
Author
There was a problem hiding this comment.
On 09/13/2016 12:20 PM, W. Trevor King wrote:
Follow the spec ordering and use |--disable-oom-killer|?
Fine, fixed.
Mashimiaoforce-pushed
the
generate-add-oom-killer-support
branch
2 times, most recently
from
September 13, 2016 04:53
2c99d25 to
dd638c2Comparewking
commented
Sep 13, 2016
via email
Contributor
dd638c2 looks good to me. |
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiaoforce-pushed
the
generate-add-oom-killer-support
branch
from
September 22, 2016 02:27
dd638c2 to
5caf782CompareMashimiao
commented
Sep 22, 2016
Author
PR rebased. |
mrunalp
commented
Oct 11, 2016
Contributor
LGTM |
wking pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 13, 2016
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from 5caf782opencontainers#207 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
wking pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 14, 2016
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from 5caf782opencontainers#207 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com