Uh oh!
There was an error while loading. Please reload this page.
check if Root.Path is Abs - #233
Merged
Merged
Conversation
liangchenye
commented
Oct 9, 2016
MemberAuthor
@mrunalp PTAL |
| } | ||
| configPath := path.Join(inputPath, "config.json") | ||
| configPath := filepath.Join(inputPath, "config.json") |
There was a problem hiding this comment.
should we replace all path.* to filepath.* and remove import "path" in this file?
MemberAuthor
There was a problem hiding this comment.
I think so, I modified all path in 'validate.go' by updating the PR.
Signed-off-by: liang chenye <liangchenye@huawei.com>
mrunalp
commented
Oct 11, 2016
Contributor
LGTM |
wking pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 13, 2016
Signed-off-by: liang chenye <liangchenye@huawei.com> Backported to v1.0.0.rc1 from a1ce2b1opencontainers#233 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
wking pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Oct 15, 2016
Signed-off-by: liang chenye <liangchenye@huawei.com> Backported to v1.0.0.rc1 from a1ce2b1opencontainers#233 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IsAbs check due to runtime spec changes:
https://github.com/opencontainers/runtime-spec/blob/master/config.md#root-configuration
Signed-off-by: liang chenye liangchenye@huawei.com