generate: output minimal template in default by Mashimiao · Pull Request #379 · opencontainers/runtime-tools

Mashimiao · 2017-05-11T02:36:08Z

The runtime-spec doesn't say process in container
should have such default capabilities, so remove them.

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com

wking · 2017-05-11T05:19:28Z

On Wed, May 10, 2017 at 07:36:08PM -0700, Ma Shimiao wrote: The runtime-spec doesn't say process in container should have such default capabilities, so remove them.

‘generate’ is not about spec compliance (that's ‘validate’), it's about creating a useful starting point for users. So runtime-tools maintainers are free to do whatever they like in ‘New()’ if they think it makes life easier for folks who don't have existing opinions about what they want in the spec.

Mashimiao · 2017-05-11T05:53:13Z

On 05/11/2017 01:19 PM, W. Trevor King wrote: ‘generate’ is not about spec compliance (that's ‘validate’), it's about creating a useful starting point for users.

Agree. But I think we can't make sure which capability is necessary for user, just leave it alone without default value will be better.

wking · 2017-05-11T07:10:03Z

On Wed, May 10, 2017 at 10:53:14PM -0700, Ma Shimiao wrote: But I think we can't make sure which capability is necessary for user, just leave it alone without default value will be better.

I agree, but with that approach the best default config is probably the minimal one for the platform (e.g. [1]) with the additional recommended mounts [2]. The current default is really somewhere between “useful for newcomers out of the box” and “demonstrates a bunch of things so you can trim it down”. The latter goal is also served by [3], so maybe this PR is the first stage of a pivot towards a more minimal default? [1]: https://github.com/opencontainers/runtime-spec/blob/1259a08e003658f8c4094a6bbc9f52aee29c95df/schema/test/config/good/minimal.json [2]: https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#default-filesystems [3]: https://github.com/opencontainers/runtime-spec/blob/master/config.md#configuration-schema-example

Mashimiao · 2017-05-11T07:44:46Z

In my own opinion, generate should output config info based on what runtime-spec minimally request in default. Any optional or additional fields in config should be specified by users which may be by options of command generate.

wking · 2017-05-11T07:49:35Z

On Thu, May 11, 2017 at 12:44:47AM -0700, Ma Shimiao wrote: In my own opinion, `generate` should output config info based on what runtime-spec minimally request in default.

So why is this PR just trimming the capabilities? If the goal is minimal (including the SHOULD-level mounts [1]?), you could work up a much bigger cut pretty quickly. Are there future plans for that and some reason that taking this one group of properties at a time? [1]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc5/config-linux.md#default-filesystems

Mashimiao · 2017-05-11T09:44:39Z

Before I sent this PR, I haven't think so much about minimal or not. I just found the default caps will cause runtimetest fails, so began to fix it.

mrunalp · 2017-05-12T14:36:22Z

We can use templates for minimal.

Mashimiao · 2017-05-15T03:53:36Z

@wking @mrunalp PTAL

wking

Also “minial” → “minimal” in the commit message summary and the PR topic.

wking · 2017-05-15T18:12:33Z

 Arch: runtime.GOARCH,
 },
- Root: rspec.Root{
- Path: "",


This is a REQUIRED property, so I think you should keep this. If you don't like the empty-string value, I'd be ok with a "FIXME" default.

Because option --rootfs-path has default value rootfs, then I think keep it or not doesn't matter , so removed it.

wking · 2017-05-15T18:15:00Z

- User: rspec.User{},
+ User: rspec.User{
+ UID: 0,
+ GID: 0,


These are the Go zero values, so you can stick with User: rspec.User{}. I'm not opposed to explicitly setting them (like you're currently doing in this PR) though.

wking · 2017-05-15T18:16:05Z

- Hostname: "mrsdalloway",
- Mounts: []rspec.Mount{
- {
- Destination: "/proc",


I think you want to keep this (and a few of the other entries) to follow the runtime's SHOULD.

I think that's a question.
Should we let spec should-level properties in minimal template? @wking @mrunalp

Should we let spec should-level properties in minimal template?
I think so, because there is no reason to assume all callers have "carefully weighed (the full implications) before choosing a different course". Callers who have can always clear mounts.

OK, updated

Mashimiao · 2017-06-07T08:07:17Z

@wking @mrunalp @hqhq @liangchenye PTAL

liangchenye · 2017-07-06T06:12:58Z

With this title 'output minial tempalte in default', I prefer to provide template file for 'linux/windows/solaris' directly, just like:
https://github.com/opencontainers/runtime-spec/tree/master/schema/test/config/good

Maybe we can add them to runtime-tools/contrib/templates?

Mashimiao · 2017-07-06T07:44:57Z

Agree, we can supply default good templates. But I think without users' spcified options, generate outputs minimal template is also right.

in default generate ouput which contains minial requests of spec Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>

Mashimiao force-pushed the generate-remove-def-cap branch from 0b6fe92 to 02a77b3Compare May 15, 2017 03:52

Mashimiao changed the title ~~generate: remove default capabilities~~generate: output minial template in defaultMay 15, 2017

wking reviewed May 15, 2017
View reviewed changes

Mashimiao force-pushed the generate-remove-def-cap branch from 02a77b3 to 35506cfCompare May 17, 2017 02:48

Mashimiao changed the title ~~generate: output minial template in default~~generate: output minimal template in defaultMay 17, 2017

Mashimiao force-pushed the generate-remove-def-cap branch from 35506cf to 5bea74eCompare May 23, 2017 06:43

Mashimiao mentioned this pull request Jun 16, 2017
generate errors out if an action is specified that's the same as default #395
Closed

generate: output minimal template in default
da5029b
in default generate ouput which contains minial requests of spec Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>

Mashimiao force-pushed the generate-remove-def-cap branch from 5bea74e to da5029bCompare July 6, 2017 07:48

wking mentioned this pull request Jul 11, 2017
overwrite the 'platform' value when 'host-specific' was set #415
Merged

wking mentioned this pull request Sep 14, 2017
generate: sync with runc's default spec #477
Open

Mashimiao added this to the v0.6.0 milestone Sep 26, 2017

Mashimiao mentioned this pull request Nov 7, 2017
specconv.Example(): add /proc/scsi to masked paths opencontainers/runc#1641
Merged

wking mentioned this pull request Nov 24, 2017
Unable to escape colons in option lists #470
Closed

zhouhao3 modified the milestones: v0.6.0, v1.0 May 15, 2018

Uh oh!

Conversation

Mashimiao commented May 11, 2017

Uh oh!

wking commented May 11, 2017 via email

Uh oh!

Mashimiao commented May 11, 2017 via email

Uh oh!

wking commented May 11, 2017 via email

Uh oh!

Mashimiao commented May 11, 2017

Uh oh!

wking commented May 11, 2017 via email

Uh oh!

Mashimiao commented May 11, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrunalp commented May 12, 2017

Uh oh!

Mashimiao commented May 15, 2017

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mashimiao commented Jun 7, 2017

Uh oh!

liangchenye commented Jul 6, 2017

Uh oh!

Mashimiao commented Jul 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Mashimiao commented May 11, 2017•
edited
Loading