Skip to content

Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter - #776

Merged
tianon merged 2 commits into
opencontainers:masterfrom
kolyshkin:go123
Nov 8, 2024
Merged

Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter#776
tianon merged 2 commits into
opencontainers:masterfrom
kolyshkin:go123

Conversation

@kolyshkin

@kolyshkinkolyshkin commented Aug 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Mostly a CI refresh. See commits for details.

Closes: #769

@kolyshkin
kolyshkin requested a review from a team as a code ownerAugust 15, 2024 06:44
tianon
tianon previously approved these changes Aug 15, 2024
View reviewed changes
@kolyshkin

kolyshkin commented Sep 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@opencontainers/runtime-tools-maintainers PTAL

tianon
tianon reviewed Sep 21, 2024
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
@kolyshkinkolyshkin mentioned this pull request Sep 25, 2024
Merged
@kolyshkin

kolyshkin commented Oct 1, 2024

Copy link
Copy Markdown
ContributorAuthor

@opencontainers/runtime-tools-maintainers PTAL 🙏🏻

@thaJeztahthaJeztah mentioned this pull request Oct 2, 2024
Open
1 task
@kolyshkin
cmd/oci-runtime-tool: fix govet warning
e1c9375
Found by golangci-lint v1.60.1:
cmd/oci-runtime-tool/main.go:59:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Fatalf (govet)
logrus.Fatalf(err.Error())
^
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
ci: bump Go and github actions
4c69808
Go 1.23 is released, making Go 1.21 (and older version) unsupported.
Yet, let's also keep the version from go.mod.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
thaJeztah approved these changes Oct 9, 2024
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah

thaJeztah commented Oct 9, 2024

Copy link
Copy Markdown
Member

Oh, interesting; I have a green check here, but I'm not in the maintainers list for this repo. Wondering if some permissions were set too relaxed?

@kolyshkin

kolyshkin commented Oct 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Oh, interesting; I have a green check here, but I'm not in the maintainers list for this repo. Wondering if some permissions were set too relaxed?

It looks like members of both runtime-tools-maintainers and runtime-spec-maintainers are admins here.

@kolyshkin
kolyshkin requested a review from tianonOctober 9, 2024 22:17
@kolyshkin

kolyshkin commented Oct 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@tianon we need a "still lgtm" from you here 🧔🏻

@kolyshkin

kolyshkin commented Nov 8, 2024

Copy link
Copy Markdown
ContributorAuthor

@opencontainers/runtime-tools-maintainers PTAL 🙏🏻

tianon
tianon approved these changes Nov 8, 2024
View reviewed changes

@tianontianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, sorry!

To misquote one of my favorite people, "yep yep, looks like changes"

@tianon
tianon merged commit f7e3563 into opencontainers:masterNov 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianontianontianon approved these changes
@thaJeztahthaJeztahthaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin@thaJeztah@tianon