Skip to content

Add time namespace / TimeOffsets check and helper - #784

Merged
kolyshkin merged 1 commit into
opencontainers:masterfrom
champtar:time-ns
Dec 5, 2025
Merged

Add time namespace / TimeOffsets check and helper#784
kolyshkin merged 1 commit into
opencontainers:masterfrom
champtar:time-ns

Conversation

@champtar

@champtarchamptar commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

Fixes#783

@champtar
champtar requested a review from a team as a code ownerJanuary 23, 2025 03:38
@champtar

champtar commented Feb 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@tianon@kolyshkin@cyphar ping as you are the last 3 to have merged code here

kolyshkin
kolyshkin previously approved these changes Mar 1, 2025
View reviewed changes

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkinkolyshkin added this to the v0.10.0 milestone Mar 1, 2025
cyphar
cyphar requested changes May 23, 2025
View reviewed changes

@cypharcyphar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires timeOffsets support to really be usable. time namespaces without an offset aren't really any different to just using the host timens.

@champtar

champtar commented May 23, 2025

Copy link
Copy Markdown
ContributorAuthor

@cyphar added a check and an helper, is this what you were thinking ?
If not can you point at exactly what I should add ?

@champtarchamptar changed the title Add time namespaceAdd time namespace / TimeOffsets check and helperMay 23, 2025
@champtar
Add time namespace / TimeOffsets check and helper
6072004
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
@champtar
champtar requested a review from cypharJune 2, 2025 12:21
@champtar

champtar commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Ping @cyphar

@champtar

champtar commented Aug 11, 2025

Copy link
Copy Markdown
ContributorAuthor

@cyphar can you review again ?

kolyshkin
kolyshkin approved these changes Oct 1, 2025
View reviewed changes

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@champtar

champtar commented Oct 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Do I need to do anything to get this merged ? (rebase so CI pass or ...)

@kolyshkin

kolyshkin commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Hmm, I don't know why CI is not kicking in. Let's close/reopen to kick it.

@kolyshkinkolyshkin reopened this Dec 5, 2025
@kolyshkin

kolyshkin commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

(it was waiting for approval to run CI, yet the "needs approval" was not shown unless you go to the CI job)

@kolyshkin
kolyshkin merged commit 5e63903 into opencontainers:masterDec 5, 2025
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cypharcypharcyphar approved these changes
@kolyshkinkolyshkinkolyshkin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.10.0

Development

Successfully merging this pull request may close these issues.

time namespace missing

3 participants

@champtar@kolyshkin@cyphar