Skip to content

runtime-spec: bump to v1.3.0, fixup for backward incompatible linux PIDs limit type change . - #795

Merged
kolyshkin merged 3 commits into
opencontainers:masterfrom
klihub:fixes/spec-linux-pids-limit-is-ptr
Nov 14, 2025
Merged

runtime-spec: bump to v1.3.0, fixup for backward incompatible linux PIDs limit type change .#795
kolyshkin merged 3 commits into
opencontainers:masterfrom
klihub:fixes/spec-linux-pids-limit-is-ptr

Conversation

@klihub

@klihubklihub commented Nov 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR bumps our opencontainers runtime-spec dependency to the latest tagged v1.3.0.

Unfortunately v1.3.0 brings a backward incompatible change, switching the Linux PID limit from int64 to *int64. Make corresponding changes in generate/generate.go. Also, add an UnlimitedPidsLimit = -1 const to codify what is the correct Limit setting for unlimited PIDs.

Note: This PR is stacked on #797, a separate PR to bump golangci-lint to v2 and fix existing linter issues.

@klihub
klihub requested a review from a team as a code ownerNovember 4, 2025 10:37
@klihub
klihubforce-pushed the fixes/spec-linux-pids-limit-is-ptr branch 2 times, most recently from 1227392 to cbbb466CompareNovember 4, 2025 12:22
@klihubklihub mentioned this pull request Nov 4, 2025
Merged
@klihubklihub changed the title runtime-spec: bump to v1.3.0.runtime-spec: bump to v1.3.0, fixup for backward incompatible linux PIDs limit type change .Nov 4, 2025
@klihubklihub mentioned this pull request Nov 4, 2025
Closed
@aojeaaojea mentioned this pull request Nov 4, 2025
Closed
aojea
aojea reviewed Nov 4, 2025
View reviewed changes
Comment threadcgroups/cgroups_v1.go
aojea
aojea reviewed Nov 4, 2025
View reviewed changes
Comment threadgenerate/generate.go Outdated
@aojea

aojea commented Nov 4, 2025

Copy link
Copy Markdown

ping @cyphar for guidance, since was the author of opencontainers/runtime-spec@869b2d5

marquiz
marquiz reviewed Nov 4, 2025
View reviewed changes
Comment threadgenerate/generate.go Outdated
@klihub
klihubforce-pushed the fixes/spec-linux-pids-limit-is-ptr branch from cbbb466 to 4b5fec9CompareNovember 4, 2025 14:54
@AkihiroSudaAkihiroSuda mentioned this pull request Nov 4, 2025
Merged
marquiz
marquiz reviewed Nov 5, 2025
View reviewed changes

@marquizmarquiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks good to me.

Comment threadgenerate/generate.go
@elezarelezar mentioned this pull request Nov 5, 2025
Merged
@mtrmacmtrmac mentioned this pull request Nov 5, 2025
Merged
1 task
kolyshkin
kolyshkin reviewed Nov 6, 2025
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
kolyshkin
kolyshkin reviewed Nov 6, 2025
View reviewed changes

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me bump golangci-lint in a separate PR, as it will be faster than commenting here.

@kolyshkin

kolyshkin commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

golangci-lint bump is at #797, PTAL

@klihub

klihub commented Nov 6, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

golangci-lint bump is at #797, PTAL

I'll do a final rebase once #797 is merged.

@klihub
klihubforce-pushed the fixes/spec-linux-pids-limit-is-ptr branch from 4b5fec9 to 58c534dCompareNovember 6, 2025 09:02
@Honny1Honny1 mentioned this pull request Nov 6, 2025
Closed
1 task
@klihub
klihub requested review from aojea and cypharNovember 6, 2025 11:20
@aojeaaojea mentioned this pull request Nov 7, 2025
Merged
@klihubklihub mentioned this pull request Nov 7, 2025
Merged
@kolyshkin

kolyshkin commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@klihub fyi #797 is merged now

@klihub
go.{mod,sum}: bump runtime-spec to v1.3.0.
b521900
Bump runtime-spec to v1.3.0. Unfortunately there is a backward
incompatible change there switching the Linux PID limit from
int64 to *int64. Update generate/generate.go accordingly. Also,
add a constant UnlimitedPidsLimit with the correct PID limit
indicating "unlimited".
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
cgroups,generate,validat{e,ion}: fix golangci-lint deprecation warnings.
5f84332
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
cgroups: treat 'max' pids.max as -1 LinuxPids.Limit in GetPidsData().
3c27840
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
klihubforce-pushed the fixes/spec-linux-pids-limit-is-ptr branch from 35dc18d to 3c27840CompareNovember 11, 2025 08:42
@klihub

klihub commented Nov 11, 2025

Copy link
Copy Markdown
ContributorAuthor

@klihub fyi #797 is merged now

@kolyshkin Rebased on latest master/HEAD.

@klihub

klihub commented Nov 11, 2025

Copy link
Copy Markdown
ContributorAuthor

ping @opencontainers/runtime-tools-maintainers

@klihub

klihub commented Nov 11, 2025

Copy link
Copy Markdown
ContributorAuthor

@cyphar@AkihiroSuda@giuseppe PTAL

@sayborassayboras mentioned this pull request Nov 11, 2025
Merged
1 task
@klihubklihub mentioned this pull request Nov 11, 2025
Merged
marquiz
marquiz reviewed Nov 11, 2025
View reviewed changes
Comment threadcgroups/cgroups_v1.go
cyphar
cyphar approved these changes Nov 11, 2025
View reviewed changes

@cypharcyphar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@klihub
klihub requested a review from marquizNovember 11, 2025 13:35
@samuelkarpsamuelkarp mentioned this pull request Nov 11, 2025
Open
@askervinaskervin mentioned this pull request Nov 12, 2025
Open
@kolyshkin

kolyshkin commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

If there's anything else that needs to be done, let's do this as a followup.

@kolyshkin
kolyshkin merged commit edf4cb3 into opencontainers:masterNov 14, 2025
9 checks passed
@klihub
klihub deleted the fixes/spec-linux-pids-limit-is-ptr branch November 17, 2025 11:49
@AkihiroSudaAkihiroSuda mentioned this pull request Nov 19, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cypharcypharcyphar approved these changes
@kolyshkinkolyshkinkolyshkin approved these changes
@aojeaaojeaAwaiting requested review from aojea
@marquizmarquizAwaiting requested review from marquiz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@klihub@aojea@kolyshkin@marquiz@cyphar