Uh oh!
There was an error while loading. Please reload this page.
Add initial version of runtimetest command: - #9
Closed
zenlint wants to merge 6 commits into
Closed
Conversation
mrunalp
commented
Jan 26, 2016
Contributor
Needs rebase. (On my review list). |
zenlintforce-pushed
the
initruntimetestCmd
branch
5 times, most recently
from
January 29, 2016 06:55
acb0c2e to
5290838Comparezenlint
commented
Jan 29, 2016
ContributorAuthor
zenlint
commented
Jan 30, 2016
ContributorAuthor
@mrunalp Any review comments plz let me know, thx. |
zenlintforce-pushed
the
initruntimetestCmd
branch
from
March 24, 2016 02:22
5c6d742 to
4a6f739Comparezenlintforce-pushed
the
initruntimetestCmd
branch
from
March 24, 2016 02:32
4a6f739 to
acc1da1CompareSigned-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
Signed-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
zenlint
commented
Mar 24, 2016
ContributorAuthor
@liangchenye I have already reabased the PR. |
| count := 0 | ||
| for { | ||
zenlint
commented
Mar 31, 2016
ContributorAuthor
@mrunalp Thanks very much, I have reviewed it myself and also fixed the format problems you pointed out. |
Signed-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
zenlintforce-pushed
the
initruntimetestCmd
branch
from
March 31, 2016 08:48
4bb50c9 to
5e909b5CompareSigned-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
Signed-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
Signed-off-by: linzhinan(zen Lin) <linzhinan@huawei.com>
liangchenye
commented
Apr 13, 2016
Member
Looks good, I have three suggestions:
|
wking added a commit
to wking/ocitools-v2
that referenced
this pull request
Feb 10, 2017
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY, ...), 2015-12-02, opencontainers#9). Signed-off-by: W. Trevor King <wking@tremily.us>
Merged
wking
commented
Mar 22, 2017
Contributor
Close now that #336 has landed? |
Mashimiao
commented
Apr 12, 2017
as #336 landed, close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial version of runtimetest command:
add unit and config for managing cases;
replace runtime_test.sh to golang realization;
Signed-off-by: zen Lin(Lin Zhinan) linzhinan@huawei.com