Uh oh!
There was an error while loading. Please reload this page.
feat: Change brand-sample from Purple to 'Autumn' - #47
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #47 +/- ##
=======================================
Coverage 93.04% 93.04% =======================================
Files 16 16 Lines 503 503 Branches 18 18 =======================================
Hits 468 468 Misses 24 24 Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aff8617 to
cfa7330Comparecfa7330 to
5b68a25Compare
I ran the new autumn palette through WCAG 2.x contrast math against The headline result: only one token is a real concern —
I initially flagged The real issue: |
feanil
commented
May 16, 2026
I think it's worth doing both of those things, we should be compliant in our example but also provide pointers to how others can keep their themes accessible. I think we should update the contrast in this PR but we can make a follow-up PR for the README update if that's easier. |
5b68a25 to
9aa0cdfComparekdmccormick
commented
May 17, 2026
Thanks for running it through the a11y checker @brian-smith-tcril , I hadn't thought to do that. I darkened brand-base to @feanil@brian-smith-tcril Can I get a 👍🏻 to merge this? |
Also, make the readme steps copy-able Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9aa0cdf to
cfb219eCompareUh oh!
There was an error while loading. Please reload this page.
This makes the theme changes more severe so that it's easier to tell whether or not the theme is working.
Claude generated the theme based on my request to look at the design tokens docs and then make "something like Boston in the fall" Let me know if the provided style dict is following best practices or not. If not, then I'm happy to re-generate it--I'd like that whatever we check in here is a good example how people actually might want to do things.
I wanted to include typography changes, too, and I did successfully make a version of this which customized all the font-family CSS attributes. But, I ran out of time before realizing that I'd need to get all those fonts loaded into the page in order to actually work, and I didn't know how to do that.
Screenshot (BEFORE REVIEW FEEDBACK):
Screenshot (AFTER REVIEW FEEDBACK):
See also: the included authn screenshot.