Skip to content

refactor: Make brand-sample one layer simpler - #49

Merged
kdmccormick merged 2 commits into
mainfrom
kdmccormick/brand-simpler
May 17, 2026
Merged

refactor: Make brand-sample one layer simpler#49
kdmccormick merged 2 commits into
mainfrom
kdmccormick/brand-simpler

Conversation

@kdmccormick

@kdmccormickkdmccormick commented May 16, 2026

Copy link
Copy Markdown
Member

This collapses brand-sample/src into brand-sample. The extra layer did not seem to be serving a purpose; it actually confused me over and over again when I was copying files around to debug tutor-contrib-paragon :P

This also drops the Makefile and merges its on rule (build) into
package.json, removing the unnecessary package.json->Makefile->package.json
indirection that was going on.

No AI use.

@codecov

codecovBot commented May 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.04%. Comparing base (ccc9a1d) to head (7d52bf5).

Additional details and impacted files
@@ Coverage Diff @@## main #49 +/- ##
=======================================
Coverage 93.04% 93.04% =======================================
Files 16 16 Lines 503 503 Branches 18 18 =======================================
Hits 468 468 Misses 24 24 Partials 11 11 
FlagCoverage Δ
unittests93.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kdmccormick
kdmccormickforce-pushed the kdmccormick/brand-simpler branch 2 times, most recently from c4e2363 to 1ce0fd8CompareMay 16, 2026 01:51
This collapses brand-sample/src into brand-sample.
The extra layer did not seem to be serving a purpose.
It confused me over and over again when I was debugging tutor-contrib-paragon.
This also drops the Makefile and merges its on rule (build) into
package.json, removing the unnecessary package.json<->Makefile
indirection that was going on.
@@ -1 +1,2 @@
!dist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was needed because of the top-level .gitignore in this repo. Removing it won't break anything, but if someone were to delete the dist dir and commit the removal we'd need to force-add it to get it back.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, fixed, thanks

@brian-smith-tcrilbrian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense. The only real benefit to having the package live in a src subdir was not having the output of builds tied to the checked-in dist.

@kdmccormick
kdmccormick merged commit d4f3801 into mainMay 17, 2026
9 checks passed
@kdmccormick
kdmccormick deleted the kdmccormick/brand-simpler branch May 17, 2026 00:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kdmccormick@brian-smith-tcril