Skip to content

fix: restrict condition name to 50 characters - #187

Open
d-jeffery wants to merge 1 commit into
mainfrom
fix/condition-validation
Open

fix: restrict condition name to 50 characters#187
d-jeffery wants to merge 1 commit into
mainfrom
fix/condition-validation

Conversation

@d-jeffery

Copy link
Copy Markdown

Description

Restrict character limit of condition down to 50 characters. Left the patterns as they were.

References

openfga/language#319

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery
d-jeffery requested a review from a team as a code ownerAugust 15, 2024 20:15
@d-jeffery
d-jeffery requested a review from rhamzehAugust 15, 2024 20:15
@d-jeffery
d-jefferyforce-pushed the fix/condition-validation branch from 4ba8caa to 9403babCompareAugust 15, 2024 20:19
@d-jeffery
d-jeffery requested review from a team as code ownersAugust 15, 2024 20:19
string name = 1 [
(validate.rules).string = {
pattern: "^[^\\s]{2,256}$"
pattern: "^[^\\s]{1,50}$"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific byte length that we are targeting, or are we only concerned about character count? Considering byte length, a maximum of 200 bytes (UTF-8 4-byte characters) would be valid for 50 characters.

if the assumption is that we are limiting to 50 8-bit characters for a maximum of 50 bytes, then more validations will need to be put into place.

@curfew-marathon

Copy link
Copy Markdown

This PR has had no human activity for 90 days, so it has been marked lifecycle/stale.

This is automated backlog grooming, not a judgment on the work.

What happens next, unless there is activity:

  • In 30 days, it will move to lifecycle/closing-soon
  • 30 days after that, it will be closed

To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add lifecycle/frozen.

@curfew-marathoncurfew-marathon added the lifecycle/stale No human activity in 90 days label Jul 3, 2026
@curfew-marathon

Copy link
Copy Markdown

This PR has had no human activity for 30 days since being marked lifecycle/stale, so it has now been marked lifecycle/closing-soon.

It will be closed in 30 days unless there is new activity.

If the work still matters, this is the moment to say so: leave a comment, push a commit, or ask a maintainer to add lifecycle/frozen if it should be kept open long-term.

If this work is no longer being pursued, no action is needed.

@curfew-marathoncurfew-marathon added lifecycle/closing-soon Final warning before auto-close and removed lifecycle/stale No human activity in 90 days labels Aug 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/closing-soonFinal warning before auto-close

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@d-jeffery@curfew-marathon@senojj